Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow generate transaction template #1771

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix flow generate transaction template #1771

merged 1 commit into from
Sep 24, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Sep 24, 2024

Closes #1763


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.68%. Comparing base (f99a061) to head (34a8b5a).

Files with missing lines Patch % Lines
internal/super/generate.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1771   +/-   ##
=======================================
  Coverage   29.68%   29.68%           
=======================================
  Files          89       89           
  Lines        5191     5191           
=======================================
  Hits         1541     1541           
  Misses       3463     3463           
  Partials      187      187           
Flag Coverage Δ
unittests 29.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink merged commit 605907c into master Sep 24, 2024
11 checks passed
@jribbink jribbink deleted the jribbink/tx-gen branch September 24, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flow generate transaction generates a script
4 participants