Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make add by core contract case insensitive #1770

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Sep 24, 2024

Closes #1769


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Sep 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 29.65%. Comparing base (f99a061) to head (d91415d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/dependencymanager/add.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1770      +/-   ##
==========================================
- Coverage   29.68%   29.65%   -0.04%     
==========================================
  Files          89       89              
  Lines        5191     5197       +6     
==========================================
  Hits         1541     1541              
- Misses       3463     3469       +6     
  Partials      187      187              
Flag Coverage Δ
unittests 29.65% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink merged commit 30eaa63 into master Sep 24, 2024
5 checks passed
@jribbink jribbink deleted the jribbink/lower-alias branch September 24, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make flow deps add <core contract> case insensitive
4 participants