Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IPC API for FSDAX #878

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Nov 6, 2024

Description

Enable IPC API for FSDAX.
FSDAX requires 2 MB page size.

Requires: #887

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau force-pushed the Enable_IPC_API_for_FSDAX branch 2 times, most recently from bde62e7 to 27ab84a Compare November 7, 2024 09:06
@ldorau ldorau changed the title [DRAFT] Enable IPC API for FSDAX Enable IPC API for FSDAX Nov 7, 2024
@ldorau ldorau marked this pull request as ready for review November 7, 2024 09:07
@ldorau ldorau requested a review from a team as a code owner November 7, 2024 09:07
@ldorau ldorau force-pushed the Enable_IPC_API_for_FSDAX branch 2 times, most recently from 2f94e82 to fa4f9b6 Compare November 7, 2024 09:59
src/provider/provider_file_memory.c Outdated Show resolved Hide resolved
src/provider/provider_file_memory.c Show resolved Hide resolved
@ldorau ldorau force-pushed the Enable_IPC_API_for_FSDAX branch 3 times, most recently from 28d6fbc to f09b12d Compare November 7, 2024 14:56
@ldorau ldorau requested a review from lplewa November 7, 2024 21:14
Make utils_mmap_file() detect DAX using MAP_SYNC flag.
Add bool *map_sync argument to utils_mmap_file().
map_sync is set to true only if memory was mapped with MAP_SYNC,
what means it is a DAX file/device.

Signed-off-by: Lukasz Dorau <[email protected]>
The UMF_MEM_MAP_SYNC flag is DEPRECATED,
(UMF_MEM_MAP_SHARED should be used instead).
UMF_MEM_MAP_SYNC will be removed in the next release.

Verify if /dev/dax was mapped with MAP_SYNC.

Signed-off-by: Lukasz Dorau <[email protected]>
FSDAX requires 2 MB page size.

Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
Fix warnings about format specifies type:
warning: format specifies type 'void *' but the argument \
         has type 'char *' [-Wformat-pedantic]

Signed-off-by: Lukasz Dorau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants