Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UMF_LEVEL_ZERO_INCLUDE_DIR in an example #877

Open
lukaszstolarczuk opened this issue Nov 6, 2024 · 3 comments
Open

Use UMF_LEVEL_ZERO_INCLUDE_DIR in an example #877

lukaszstolarczuk opened this issue Nov 6, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@lukaszstolarczuk
Copy link
Contributor

We could add in any of the examples, usage of the UMF_LEVEL_ZERO_INCLUDE_DIR variable. Currently we test it only via UR build.

Ref. #872

@lukaszstolarczuk lukaszstolarczuk added the enhancement New feature or request label Nov 6, 2024
@vinser52
Copy link
Contributor

vinser52 commented Nov 6, 2024

Why not to extend regular testing?

@lukaszstolarczuk
Copy link
Contributor Author

lukaszstolarczuk commented Nov 6, 2024

examples are part of our regular testing 😉

I saw this like - either we set it up in some CMake (like for standalone examples) or add it in (every?) CI workflow file, which might be too much...? While resolving this issue we can iterate these (and other) scenarios and pick the best one.

@vinser52
Copy link
Contributor

vinser52 commented Nov 7, 2024

I saw this like - either we set it up in some CMake (like for standalone examples) or add it in (every?)

L0 tests are run only on L0 runners. So we do not need to add such scenario to every CI workflow, just to the L0 one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants