Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ensure different owner #4

Merged
merged 3 commits into from
Jun 18, 2024
Merged

refactor: ensure different owner #4

merged 3 commits into from
Jun 18, 2024

Conversation

johnletey
Copy link
Contributor

@johnletey johnletey commented Jun 3, 2024

This PR ensures that a different owner is provided when starting an ownership transfer.

Closes #3.

Summary by CodeRabbit

  • New Features
    • Added branch filters for main and v* in the unit tests workflow.
    • Enhanced ownership transfer validation to prevent transfers to the same owner.
    • Improved error messages and validations related to ownership and pending ownership.
    • Updated module spec file references in the repository.
    • Modified initialization of the Keeper instance with a custom codec and interface registry.
    • Updated comments in the blocklist address query test.

@johnletey johnletey self-assigned this Jun 3, 2024
Copy link

coderabbitai bot commented Jun 3, 2024

Walkthrough

A series of updates were made across the codebase to enhance ownership transfer validation and error handling. Branch filters were added to the unit test workflow, Go version was adjusted, and various methods now prevent transferring ownership to the same owner. Error messages were refined and new validations introduced, ensuring more robust functionality.

Changes

File Change Summary
.github/workflows/unit-tests.yaml Branch filters added, Go version modified to '1.21'
x/aura/keeper/msg_server.go
x/aura/keeper/msg_server_blocklist.go
x/aura/keeper/msg_server_blocklist_test.go
x/aura/keeper/msg_server_test.go
Updated TransferOwnership methods to prevent transfer to the same owner
x/aura/spec/02_messages.md
x/aura/spec/02_messages_blocklist.md
Added validation for new owner not being the current owner
x/aura/types/blocklist/errors.go Updated error codes and messages related to blocklist ownership
x/aura/types/errors.go Reordered and updated error messages for ownership-related conditions
.github/README.md Updated reference to module's spec files
utils/mocks/aura.go Modified initialization of Keeper instance
x/aura/keeper/query_server_blocklist_test.go Updated comment for test function

Poem

Code changes dance like springtime breeze,
Ownership checks put minds at ease.
Errors refined, validations bright,
Rabbit's code, a joyful sight. 🐇✨


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@johnletey johnletey merged commit 44c811a into main Jun 18, 2024
7 of 8 checks passed
@johnletey johnletey deleted the hal-01 branch June 18, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HAL-01: Ensure Different Owner
1 participant