From cf3aac38cf1fb0399053373d118730853a7448aa Mon Sep 17 00:00:00 2001 From: onderonur Date: Sun, 18 Aug 2024 03:46:13 +0300 Subject: [PATCH] removed unnecessary condition from gh action --- .github/composite-actions/install/action.yml | 2 +- .github/workflows/nextjs.yml | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/composite-actions/install/action.yml b/.github/composite-actions/install/action.yml index b1f380e..0f04c6a 100644 --- a/.github/composite-actions/install/action.yml +++ b/.github/composite-actions/install/action.yml @@ -7,7 +7,7 @@ runs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: 20 + node-version-file: '.nvmrc' cache: npm - name: Install dependencies diff --git a/.github/workflows/nextjs.yml b/.github/workflows/nextjs.yml index 33e0aa7..56be340 100644 --- a/.github/workflows/nextjs.yml +++ b/.github/workflows/nextjs.yml @@ -52,11 +52,6 @@ jobs: # Deployment job deploy: - # Since `workflow_run` only has 3 activity types (`completed`, `requested` and `in_progress`), - # even if `Quality` workflow gets completed by failing, this workflow starts to run. - # To prevent this, we add a condition here. - # https://github.com/orgs/community/discussions/26238#discussioncomment-3250901 - if: ${{ github.event.workflow_run.conclusion == 'success' }} environment: name: github-pages url: ${{ steps.deployment.outputs.page_url }}