Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sm-gen]Handle Unsupported Data Types in determineFhirDataType #250

Open
2 of 6 tasks
sharon2719 opened this issue Aug 2, 2024 · 0 comments · May be fixed by #280
Open
2 of 6 tasks

[sm-gen]Handle Unsupported Data Types in determineFhirDataType #250

sharon2719 opened this issue Aug 2, 2024 · 0 comments · May be fixed by #280
Assignees

Comments

@sharon2719
Copy link
Contributor

sharon2719 commented Aug 2, 2024

Description:

The current implementation of the determineFhirDataType function primarily handles a limited set of FHIR data types such as boolean, integer, decimal, date, dateTime, and string. To ensure comprehensive data type handling, we need to enhance this function to recognize and process additional FHIR data types and address potential edge cases. This improvement will ensure that the function can accurately determine the correct FHIR data type for a wider range of inputs, leading to more robust and reliable code execution.

Tasks:

  • Expand Data Type Recognition:
    Add support for additional FHIR data types such as Quantity, CodeableConcept, Coding, Identifier, Reference, Period, Timing, Range, and any other relevant types.

  • Implement Edge Case Handling:
    Address edge cases where the input value might not strictly match the expected format. This includes handling null values, empty strings, and mixed-type inputs (e.g., strings that look like numbers but contain non-numeric characters).

  • Regular Expression Enhancements:
    Enhance the regular expressions used for data type detection to be more robust and accurate. Ensure that they correctly identify the intended data types and avoid false positives or negatives.

  • Default Fallback:
    Implement a default fallback mechanism for unsupported or unrecognized data types. This will ensure that the function returns a meaningful value or error message rather than failing silently.

  • Logging and Error Reporting:
    Add logging and error reporting to provide insights into the function's execution. This will help identify and debug issues related to data type determination.

  • Unit Tests:
    Write unit tests to validate the functionality of the enhanced determineFhirDataType function. Ensure that all supported data types and edge cases are covered by the tests.

@sharon2719 sharon2719 changed the title Handle Unsupported Data Types in determineFhirDataType [sm-gen]Handle Unsupported Data Types in determineFhirDataType Aug 2, 2024
@sharon2719 sharon2719 removed the Draft label Aug 7, 2024
@sharon2719 sharon2719 self-assigned this Aug 20, 2024
@sharon2719 sharon2719 linked a pull request Aug 28, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant