Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external: mcap disable tests #37

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

filippobrizzi
Copy link
Collaborator

No description provided.

@@ -145,4 +145,5 @@ add_cmake_dependency(
GIT_REPOSITORY "https://github.com/filippobrizzi/mcap.git"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume that a mirror, should we transfer it to olympus-robotics?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point actually, I was hoping to get my PR merged soon in the main repo, but it could take time so yes we should move it there

Copy link
Collaborator

@floriantschopp floriantschopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@filippobrizzi filippobrizzi merged commit 28bee7f into main Mar 25, 2024
3 checks passed
@filippobrizzi filippobrizzi deleted the external/mcap_disable_tests branch March 25, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants