Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Externalize lodash-es to reduce bundle size #245

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Externalize lodash-es to reduce bundle size #245

merged 2 commits into from
Mar 11, 2024

Conversation

NikhilVerma
Copy link
Contributor

@NikhilVerma NikhilVerma commented Mar 10, 2024

  • We do need to consider how to lazily load the emoji mart code in future because this still doesn't fix the fact that the final client bundler will end up bundling everything together in the Flow bundle
  • Same goes for other bigger libraries

Checklist for raising a PR

  • Gone through UX documnetation for adding new features.
  • All necessary unit tests covered.
  • Required comments added for generating component manifest file? you can find details here
  • Did you check the contributing doc?
  • Did you check the existing issues for similar queries?

Describe your PR

Add additional question here

  • Yes
  • No
  • NA

@NikhilVerma NikhilVerma changed the title Externalize emoji mart data and lodash-es to reduce bundle size Externalize @emoji-mart/data and lodash-es to reduce bundle size Mar 10, 2024
…le size

- We do need to consider how to lazily load the emoji mart code in future
because this still doesn't fix the fact that the final client bundler will end
up bundling everything together in the Flow bundle
- Same goes for other bigger libraries
@datapipes-robot datapipes-robot bot added size/XS and removed size/S labels Mar 11, 2024
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikas-cldcvr vikas-cldcvr changed the title Externalize @emoji-mart/data and lodash-es to reduce bundle size Externalize lodash-es to reduce bundle size Mar 11, 2024
@datapipes-robot datapipes-robot bot added the lgtm label Mar 11, 2024
@vikas-cldcvr vikas-cldcvr merged commit c7b5487 into main Mar 11, 2024
5 checks passed
@vikas-cldcvr vikas-cldcvr deleted the bundle-size branch March 11, 2024 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants