Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove people model #1102

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Remove people model #1102

merged 2 commits into from
Nov 7, 2024

Conversation

pdelboca
Copy link
Member

This PR removes the old Person model.

Follow up of #1096 #1098 #1100

This is the last "model content managed" piece of code that we have in the system.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (8b69fb9) to head (0455ae5).
Report is 45 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1102      +/-   ##
===========================================
- Coverage    88.78%   88.24%   -0.55%     
===========================================
  Files           99       90       -9     
  Lines         1222      910     -312     
  Branches        50       38      -12     
===========================================
- Hits          1085      803     -282     
+ Misses         135      107      -28     
+ Partials         2        0       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdelboca pdelboca merged commit faad252 into develop Nov 7, 2024
2 checks passed
@pdelboca pdelboca deleted the remove-people-model branch November 7, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants