Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3.4.2 and chardet-2.3.0 issues with messytables reinstalling older version chardet-2.1.1 #114

Open
ghost opened this issue Dec 25, 2014 · 5 comments

Comments

@ghost
Copy link

ghost commented Dec 25, 2014

I was attempting to use: https://github.com/edcrewe/django-csvimport

Which uses messytables to guesstimate csv/table information.

However messytables is uninstalling chardet2.3.0 and replacing it with an older version (2.1.1), which does not work with python3.4.2

(django_env) bob@bob-NE722:~/django_mysql_test/mysql_connector$ pip3 show chardet

---
Name: chardet
Version: 2.1.1
Location: /home/bob/django_mysql_test/django_env/lib/python3.4/site-packages
Requires: 

Does messytables have a development branch that is being ported to python3?

@rossjones
Copy link
Contributor

don't know about python3, Happy to take a look after the weekend though.

@rossjones rossjones self-assigned this Dec 25, 2014
@domoritz
Copy link
Contributor

Looks like pdftables should update its pdfminer version to be python 3 compatible. @rossjones when we make messytables python 3 compatible, let's enable the travis tests for python 3.

@ghost
Copy link
Author

ghost commented Dec 27, 2014

@rossjones

Not sure what would need to be changed https://github.com/okfn/messytables/blob/master/setup.py#L44 but == seems a bit restrictive would >= be sufficient? Or would it break stuff?

Please let me know if there is anything that I can test, or do, I am interested in learning the ropes on porting code, although I am not at all sure if this would be the right outlet to start doing that?
Thanks.

@domoritz
Copy link
Contributor

I tried the latest chardet and at least the unittests pass. The problem are other dependencies.

@scraperdragon
Copy link

The py23 branch uses much updated versions of many of the dependancies; I think that in the early Py3 era there were an awful lot of libraries which had a major version change to support Py3 which didn't support Py2; however they've since all become Py23 polyglot.

So we can safely update the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants