Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version is still 0.4.2 in 1.1.0-rc1 metadata #59

Open
musicinmybrain opened this issue Feb 28, 2024 · 1 comment
Open

Version is still 0.4.2 in 1.1.0-rc1 metadata #59

musicinmybrain opened this issue Feb 28, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@musicinmybrain
Copy link

As of 1.1.0-rc1, the version in the package, which ends up in the wheel metadata, is still at 0.4.2.

__version__ = "0.4.2"

Please make sure this matches the actual version for the 1.1.0 final release. Thanks!

lbeckman314 added a commit that referenced this issue Feb 29, 2024
- Fix version to match PyPi release (#59)
@lbeckman314
Copy link
Member

lbeckman314 commented Feb 29, 2024

Good catch! Just updated the version in the release-1.1.0 branch to match that on PyPi.

__version__ = "1.1.0-rc.1"

Will keep this value in sync in future version bumps, and update master and develop branches when the release branch is merged.

Thanks for finding this!

@lbeckman314 lbeckman314 self-assigned this Feb 29, 2024
@lbeckman314 lbeckman314 added this to the 1.0.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants