CONTRIBUTING: Proposal #90
Conversation
Proposal to improve the efficiency of development on oh-my-bash project Fixes: ohmybash#89 Fixes: ohmybash#88 Fixes: ohmybash#86 Partially Fixes: ohmybash#85 Partially Fixes: ohmybash#83 Signed-off-by: Jacob Hrbek <[email protected]>
|
@nntoan You dismissed it, but commented in a way that seems like approval, please clarify. |
Kreyren
added
P3 - Normal
|
Assigned P2 since this is maintainance improvement issue. |
|
|
||
| Oh-My-Bash is a community-driven project. Contribution is welcome, encouraged and appreciated. | ||
| It is also essential for the development of the project. | ||
| Oh-My-Bash is Free and Open Source project under the terms of GNU General Public License v2.0 relying on contributions from third parties. |
There was a problem hiding this comment.
@Kreyren Can you please update to a new contributing proposal to match with our current License?
Thanks.
There was a problem hiding this comment.
Now we are licensing OMB with the MIT license.
| You can also take a look at the [FAQ](https://github.com/ohmybash/oh-my-bash/wiki/FAQ) | ||
| to be sure your contribution has not already come up. | ||
| ### Quality Assurance (QA) | ||
| All merge requests have to pass spellcheck (https://www.shellcheck.net/) unless stated otherwise. |
There was a problem hiding this comment.
typo spellcheck -> shellcheck
| All merge requests have to pass spellcheck (https://www.shellcheck.net/) unless stated otherwise. | |
| All merge requests have to pass shellcheck (https://www.shellcheck.net/) unless stated otherwise. |
The same typos are also found in other lines.
|
|
||
| Oh-My-Bash is a community-driven project. Contribution is welcome, encouraged and appreciated. | ||
| It is also essential for the development of the project. | ||
| Oh-My-Bash is Free and Open Source project under the terms of GNU General Public License v2.0 relying on contributions from third parties. |
There was a problem hiding this comment.
Now we are licensing OMB with the MIT license.
|
|
||
| ### Getting started | ||
|
|
||
| ## Merge Requests |
There was a problem hiding this comment.
As this is GitHub (but not GitLab or other services), it is more natural to call it Pull Requests. Any thoughts?
akinomyoga
added
P5 - Lowest priority
|
Similarly to #99 (comment), I lowered the priority of this PR. I don't have a plan to merge this PR as is. One reason is that the contents of Another reason is that it seems difficult for me to judge whether the set of changes in this PR would make sense. The original comment of this PR contains many references to the existing issues, but I don't see which part of the change tries to solve which issue. The change set in this PR doesn't seem to be directly related to the mentioned issues, but this PR seems like overall refactoring. The refactoring change and the issue resolution need to be separated. I think the existing contents of |
Proposal to improve the efficiency of development on oh-my-bash project
Fixes: #89
Fixes: #88
Fixes: #86
Bug: #85 - Partially fixes
Bug: #83 - Partially fixes
Signed-off-by: Jacob Hrbek [email protected]