Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws completion #492

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Aws completion #492

wants to merge 4 commits into from

Conversation

johnf
Copy link
Contributor

@johnf johnf commented Oct 28, 2023

Add completion to the aws profile plugin.
Also did a bit of cleanup for deprecations etc

@akinomyoga
Copy link
Contributor

@johnf Thank you for your contribution, but I'm not familiar with the history and changes of AWS settings. Could you provide the contexts for each commit?

@johnf
Copy link
Contributor Author

johnf commented Nov 19, 2023

@akinomyoga Let me know if you want me to expand on the messages of the commits themselves but the context is

  • remove unneeded AWS_HOME variable - AWS_HOME is not used by the SDKs. I think this was being used as a shortcut in the zsh scripts this was borrowed from
  • remove deprecated AWS_DEFAULT_PROFILE - This env variable has not been used by any of the SDKs in years, and is unneeded. AWS_PROFILE has been the convention for a long time
  • Add completion - This adds completion for the asp command. The aws config file has sections delimited by [foo] for each profile name
  • Remove unused rprompt (left over from zsh?) - rprompt is a zshism I believe, again this if from the old zsh code

@akinomyoga
Copy link
Contributor

Thank you for the explanation.

  • remove unneeded AWS_HOME variable - AWS_HOME is not used by the SDKs. I think this was being used as a shortcut in the zsh scripts this was borrowed from

I would like to keep the backward compatibility. There is no insurance that no OMB user uses the variable AWS_HOME in their ~/.bashrc [1]. Is there a strong reason to remove the variable, e.g., are any problems caused by the variable? Or another way is to mark AWS_HOME as deprecated by _omb_deprecate_declare 20000 AWS_HOME while keeping the variable.

By the way, I find ohmyzsh/ohmyzsh@543044e where AWS_CONFIG_FILE is used for ~/.aws/config.

  • remove deprecated AWS_DEFAULT_PROFILE - This env variable has not been used by any of the SDKs in years, and is unneeded. AWS_PROFILE has been the convention for a long time

For the same reason, do we need to remove the variable? OMZ still seems to keep the legacy name. This can be marked deprecated by _omb_deprecate_declare 20000 AWS_DEFAULT_PROFILE AWS_PROFILE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants