{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":1345214,"defaultBranch":"develop","name":"ox","ownerLogin":"ohler55","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2011-02-09T05:56:41.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/118856?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1716853199.0","currentOid":""},"activityList":{"items":[{"before":"30b4c1bbe94651e3c7995307555a8f504cc03fac","after":"cd8511588e0bfdc867e8d5249950138da35fa012","ref":"refs/heads/develop","pushedAt":"2024-09-01T21:13:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Suppress \"warning: 'strncpy' specified bound depends on the length of the source argument\" (#361)\n\nThis patch will suppress the following warning with compiling gcc:\r\n\r\n```\r\nsax_buf.c: In function 'read_from_str':\r\nsax_buf.c:201:5: warning: 'strncpy' specified bound depends on the length of the source argument [-Wstringop-truncation]\r\n  201 |     strncpy(buf->tail, buf->in.str, cnt);\r\n      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\nsax_buf.c:197:11: note: length computed here\r\n  197 |     cnt = strlen(buf->in.str) + 1;\r\n      |           ^~~~~~~~~~~~~~~~~~~\r\n```\r\n\r\nIf strncpy is used, we should pass count argument as a value of source boundary.\r\n\r\nIn this case, it might be `strncpy(buf->tail, buf->in.str, max);`\r\n\r\nThis patch will use `memcpy` instead becaseu copied length is already known.\r\n\r\nRef. https://stackoverflow.com/a/56782476","shortMessageHtmlLink":"Suppress \"warning: 'strncpy' specified bound depends on the length of…"}},{"before":"049ecbf8f345873753f4d4904bc5d0a50bd324f2","after":"30b4c1bbe94651e3c7995307555a8f504cc03fac","ref":"refs/heads/develop","pushedAt":"2024-09-01T20:31:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Suppress \"old style definition\" warning (#360)\n\nThis patch will suppress following warning message when compile ox with gcc\r\n\r\n```\r\n$ cd ext/ox\r\n$ ruby extconf.rb\r\n$ make\r\n...\r\nintern.c: In function 'ox_hash_init':\r\nintern.c:70:6: warning: old-style function definition [-Wold-style-definition]\r\n   70 | void ox_hash_init() {\r\n      |      ^~~~~~~~~~~~\r\n...\r\n```","shortMessageHtmlLink":"Suppress \"old style definition\" warning (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2499661682\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/360\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/360/hovercard\" href=\"https://github.com/ohler55/ox/pull/360\">#360</a>)"}},{"before":"1990ad21b03e309081b34e6a9dc5ff7cacc2e2e3","after":"049ecbf8f345873753f4d4904bc5d0a50bd324f2","ref":"refs/heads/develop","pushedAt":"2024-09-01T18:39:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Use TypedData_Wrap_Struct() macro to suppress deprecated messages (#359)\n\nWhen compile ox gem with Ruby 3.4-dev, it show the following deprecated messages:\r\n\r\n```\r\n../../../../ext/ox/builder.c:356:29: warning: 'rb_data_object_wrap_warning' is deprecated: by TypedData [-Wdeprecated-declarations]\r\n  356 |         volatile VALUE rb = Data_Wrap_Struct(builder_class, NULL, builder_free, b);\r\n      |                             ^\r\n/Users/watson/.rbenv/versions/3.4-dev/include/ruby-3.4.0+0/ruby/internal/core/rdata.h:199:5: note: expanded from macro 'Data_Wrap_Struct'\r\n  199 |     rb_data_object_wrap(                          \\\r\n      |     ^\r\n/Users/watson/.rbenv/versions/3.4-dev/include/ruby-3.4.0+0/ruby/internal/core/rdata.h:363:31: note: expanded from macro 'rb_data_object_wrap'\r\n  363 | #define rb_data_object_wrap   RUBY_MACRO_SELECT(rb_data_object_wrap_2, RUBY_UNTYPED_DATA_WARNING)\r\n      |                               ^\r\n/Users/watson/.rbenv/versions/3.4-dev/include/ruby-3.4.0+0/ruby/internal/core/rdata.h:50:35: note: expanded from macro 'RUBY_MACRO_SELECT'\r\n   50 | #define RUBY_MACRO_SELECT(x, y)   RBIMPL_MACRO_SELECT(x, y)\r\n      |                                   ^\r\n/Users/watson/.rbenv/versions/3.4-dev/include/ruby-3.4.0+0/ruby/internal/core/rdata.h:49:35: note: expanded from macro 'RBIMPL_MACRO_SELECT'\r\n   49 | #define RBIMPL_MACRO_SELECT(x, y) x ## y\r\n      |                                   ^\r\n<scratch space>:119:1: note: expanded from here\r\n  119 | rb_data_object_wrap_1\r\n      | ^\r\n/Users/watson/.rbenv/versions/3.4-dev/include/ruby-3.4.0+0/ruby/internal/core/rdata.h:361:31: note: expanded from macro 'rb_data_object_wrap_1'\r\n  361 | #define rb_data_object_wrap_1 rb_data_object_wrap_warning\r\n      |                               ^\r\n/Users/watson/.rbenv/versions/3.4-dev/include/ruby-3.4.0+0/ruby/internal/core/rdata.h:277:1: note: 'rb_data_object_wrap_warning' has been explicitly marked deprecated here\r\n  277 | RBIMPL_ATTRSET_UNTYPED_DATA_FUNC()\r\n      | ^\r\n/Users/watson/.rbenv/versions/3.4-dev/include/ruby-3.4.0+0/ruby/internal/core/rdata.h:47:5: note: expanded from macro 'RBIMPL_ATTRSET_UNTYPED_DATA_FUNC'\r\n   47 |     RBIMPL_ATTR_DEPRECATED((\"by TypedData\"))\r\n      |     ^\r\n/Users/watson/.rbenv/versions/3.4-dev/include/ruby-3.4.0+0/ruby/internal/attr/deprecated.h:36:53: note: expanded from macro 'RBIMPL_ATTR_DEPRECATED'\r\n   36 | # define RBIMPL_ATTR_DEPRECATED(msg) __attribute__((__deprecated__ msg))\r\n      |                                                     ^\r\n```\r\n\r\nThis patch will suppress the deprecated messages.","shortMessageHtmlLink":"Use TypedData_Wrap_Struct() macro to suppress deprecated messages (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2499055365\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/359\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/359/hovercard\" href=\"https://github.com/ohler55/ox/pull/359\">#359</a>)"}},{"before":"ad232d270580414b6f2826354191ffa569b87bdc","after":"1990ad21b03e309081b34e6a9dc5ff7cacc2e2e3","ref":"refs/heads/develop","pushedAt":"2024-06-01T00:42:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"CI: Add Ruby 3.3 lane (#356)","shortMessageHtmlLink":"CI: Add Ruby 3.3 lane (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2327011940\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/356\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/356/hovercard\" href=\"https://github.com/ohler55/ox/pull/356\">#356</a>)"}},{"before":"40dc00ee515fd2ca4e718445e865c4533007c5f3","after":"ad232d270580414b6f2826354191ffa569b87bdc","ref":"refs/heads/develop","pushedAt":"2024-06-01T00:41:15.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Add bigdecimal as dependency gem (#355)\n\nThe bigdecimal gem will be changed bundled gem since Ruby 3.4.0.\r\nhttps://www.ruby-lang.org/en/news/2023/09/14/ruby-3-3-0-preview2-released/\r\n\r\nTo use bundled gem, it requires to specify the dependency in Gemfile.\r\n\r\nSimilar with https://github.com/ohler55/oj/pull/901","shortMessageHtmlLink":"Add bigdecimal as dependency gem (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2327010095\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/355\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/355/hovercard\" href=\"https://github.com/ohler55/ox/pull/355\">#355</a>)"}},{"before":"0a0e652db29ef2bf2c0a8995abd8ce6ea0ebf88a","after":"40dc00ee515fd2ca4e718445e865c4533007c5f3","ref":"refs/heads/develop","pushedAt":"2024-06-01T00:40:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"CI: Fix CI error (#357)\n\n* CI: Use `bundle exe` to run each test files in order to solve CI error\r\n\r\n* Add test-unit gem\r\n\r\n* Add bigdecimal as dependency gem","shortMessageHtmlLink":"CI: Fix CI error (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2327017397\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/357\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/357/hovercard\" href=\"https://github.com/ohler55/ox/pull/357\">#357</a>)"}},{"before":"c66e7650ac1c73ff32bcdb90776266991ed5329e","after":null,"ref":"refs/heads/dependabot/github_actions/jidicula/clang-format-action-4.12.0","pushedAt":"2024-05-27T23:39:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":null,"after":"5474f7e6de538f15fc77d408e0372663e5172a55","ref":"refs/heads/dependabot/github_actions/jidicula/clang-format-action-4.13.0","pushedAt":"2024-05-27T23:39:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump jidicula/clang-format-action from 4.11.0 to 4.13.0\n\nBumps [jidicula/clang-format-action](https://github.com/jidicula/clang-format-action) from 4.11.0 to 4.13.0.\n- [Release notes](https://github.com/jidicula/clang-format-action/releases)\n- [Commits](https://github.com/jidicula/clang-format-action/compare/v4.11.0...v4.13.0)\n\n---\nupdated-dependencies:\n- dependency-name: jidicula/clang-format-action\n  dependency-type: direct:production\n  update-type: version-update:semver-minor\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump jidicula/clang-format-action from 4.11.0 to 4.13.0"}},{"before":null,"after":"c66e7650ac1c73ff32bcdb90776266991ed5329e","ref":"refs/heads/dependabot/github_actions/jidicula/clang-format-action-4.12.0","pushedAt":"2024-05-20T23:42:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"---\nupdated-dependencies:\n- dependency-name: jidicula/clang-format-action\n  dependency-type: direct:production\n  update-type: version-update:semver-minor\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"---"}},{"before":"3a1eaaf4faf8151b28b304bd9b92e7e54e682f2c","after":"0a0e652db29ef2bf2c0a8995abd8ce6ea0ebf88a","ref":"refs/heads/develop","pushedAt":"2024-04-17T20:45:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Add tea.yaml","shortMessageHtmlLink":"Add tea.yaml"}},{"before":"b09ae45e89f2be6435165df33b944dcaa98417aa","after":"3a1eaaf4faf8151b28b304bd9b92e7e54e682f2c","ref":"refs/heads/develop","pushedAt":"2024-04-16T17:06:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Update gemspec with metadata","shortMessageHtmlLink":"Update gemspec with metadata"}},{"before":"5c36cf64d9683c3b0a922360b903826e89d27780","after":"b09ae45e89f2be6435165df33b944dcaa98417aa","ref":"refs/heads/master","pushedAt":"2024-03-21T14:12:56.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Release prep","shortMessageHtmlLink":"Release prep"}},{"before":"1d34947581da3b6cd57769c28a94814bfa3731e8","after":"b09ae45e89f2be6435165df33b944dcaa98417aa","ref":"refs/heads/develop","pushedAt":"2024-03-21T14:12:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Release prep","shortMessageHtmlLink":"Release prep"}},{"before":"ede3efef7d6869a857a44c0b88ce9399b9f9457b","after":"1d34947581da3b6cd57769c28a94814bfa3731e8","ref":"refs/heads/develop","pushedAt":"2024-03-21T14:07:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Correctly consider XML instruct declaration encoding when creating Hash using Ox.load(xml, mode: :hash) (#350)\n\n* Correctly consider XML instruct declaration encoding when creating Hash using Ox.load(xml, mode: :hash)\r\n\r\n* Fix rubocop linting issues\r\n\r\n* Fix rubocop linting issues\r\n\r\n* Run clang-format on C files","shortMessageHtmlLink":"Correctly consider XML instruct declaration encoding when creating Ha…"}},{"before":"a2c651bcfd38a6d37db8c02fa90da0119917eba8","after":null,"ref":"refs/heads/dependabot/github_actions/actions/checkout-4","pushedAt":"2023-09-05T07:30:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"992a873b5c0b3178320b20e490ffc75a264e8da9","after":"ede3efef7d6869a857a44c0b88ce9399b9f9457b","ref":"refs/heads/develop","pushedAt":"2023-09-05T07:30:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Bump actions/checkout from 3 to 4 (#346)\n\nBumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.\r\n- [Release notes](https://github.com/actions/checkout/releases)\r\n- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)\r\n- [Commits](https://github.com/actions/checkout/compare/v3...v4)\r\n\r\n---\r\nupdated-dependencies:\r\n- dependency-name: actions/checkout\r\n  dependency-type: direct:production\r\n  update-type: version-update:semver-major\r\n...\r\n\r\nSigned-off-by: dependabot[bot] <support@github.com>\r\nCo-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>","shortMessageHtmlLink":"Bump actions/checkout from 3 to 4 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1880954621\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/346\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/346/hovercard\" href=\"https://github.com/ohler55/ox/pull/346\">#346</a>)"}},{"before":null,"after":"a2c651bcfd38a6d37db8c02fa90da0119917eba8","ref":"refs/heads/dependabot/github_actions/actions/checkout-4","pushedAt":"2023-09-04T23:23:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump actions/checkout from 3 to 4\n\nBumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.\n- [Release notes](https://github.com/actions/checkout/releases)\n- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)\n- [Commits](https://github.com/actions/checkout/compare/v3...v4)\n\n---\nupdated-dependencies:\n- dependency-name: actions/checkout\n  dependency-type: direct:production\n  update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump actions/checkout from 3 to 4"}},{"before":"28084270c1e8ed9050a6f015835d4b1109a16d8c","after":"992a873b5c0b3178320b20e490ffc75a264e8da9","ref":"refs/heads/develop","pushedAt":"2023-07-14T21:45:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Clang format work around","shortMessageHtmlLink":"Clang format work around"}},{"before":"5c36cf64d9683c3b0a922360b903826e89d27780","after":"28084270c1e8ed9050a6f015835d4b1109a16d8c","ref":"refs/heads/develop","pushedAt":"2023-07-14T21:33:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"clang-format","shortMessageHtmlLink":"clang-format"}},{"before":"5c36cf64d9683c3b0a922360b903826e89d27780","after":null,"ref":"refs/heads/more-html-tolerant","pushedAt":"2023-07-14T21:22:27.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"}},{"before":"205d08772ff8c409a8d3ae2c04305cfa795c5f2a","after":"5c36cf64d9683c3b0a922360b903826e89d27780","ref":"refs/heads/master","pushedAt":"2023-07-14T21:21:05.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Allow unquoted attr values","shortMessageHtmlLink":"Allow unquoted attr values"}},{"before":"3c71c4050b99b49db46539813944b2a944d904bb","after":"5c36cf64d9683c3b0a922360b903826e89d27780","ref":"refs/heads/develop","pushedAt":"2023-07-14T21:20:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Allow unquoted attr values","shortMessageHtmlLink":"Allow unquoted attr values"}},{"before":null,"after":"5c36cf64d9683c3b0a922360b903826e89d27780","ref":"refs/heads/more-html-tolerant","pushedAt":"2023-07-14T00:20:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Allow unquoted attr values","shortMessageHtmlLink":"Allow unquoted attr values"}},{"before":"83eca82be8f1bae9eb453cf12ad26f057ca9c6c8","after":"3c71c4050b99b49db46539813944b2a944d904bb","ref":"refs/heads/develop","pushedAt":"2023-05-07T10:33:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Fix type check for RationalCode (#343)\n\nIt has already checked the type under `RUBY_T_FIXNUM != rb_type(h->obj)` conditions in\r\nhttps://github.com/ohler55/ox/blob/83eca82be8f1bae9eb453cf12ad26f057ca9c6c8/ext/ox/obj_load.c#L649\r\n\r\nSo this patch will check the type of `ph->obj` instead.","shortMessageHtmlLink":"Fix type check for RationalCode (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1698929259\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/343\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/343/hovercard\" href=\"https://github.com/ohler55/ox/pull/343\">#343</a>)"}},{"before":"09d4dde9f6a758cee89505d8457c6730806b27f9","after":"83eca82be8f1bae9eb453cf12ad26f057ca9c6c8","ref":"refs/heads/develop","pushedAt":"2023-05-06T23:39:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Optimize parsing option args in load (#342)\n\nIt looked up one by one to make sure that the supported options were included in passed options.\r\nThis approach of looking up the passed hash each time has an overhead.\r\n\r\nThis patch will extract key and value from the passed options using `rb_hash_foreach()` and check if they are supported or not.\r\n\r\n−            | before   | after    | result\r\n--            | --       | --       | --\r\nload          | 640.171k | 679.986k | 1.062x\r\n\r\n### Environment\r\n- MacBook Pro (M1, 2021)\r\n- macOS 13.3.1\r\n- Apple M1\r\n- clang 14.0.3\r\n- Ruby 3.2.2\r\n\r\n### Before\r\n```\r\nWarming up --------------------------------------\r\n                load    63.538k i/100ms\r\nCalculating -------------------------------------\r\n                load    640.171k (± 0.2%) i/s -      3.240M in   5.061851s\r\n```\r\n\r\n### After\r\n```\r\nWarming up --------------------------------------\r\n                load    67.690k i/100ms\r\nCalculating -------------------------------------\r\n                load    679.986k (± 0.3%) i/s -      3.452M in   5.076904s\r\n```\r\n\r\n### Test code\r\n```\r\nrequire 'bundler/inline'\r\ngemfile do\r\n  source 'https://rubygems.org'\r\n  gem 'benchmark-ips'\r\n  gem 'ox'\r\nend\r\n\r\nxml = %{\r\n<?xml version=\"1.0\"?>\r\n<Park.Animal>\r\n  <type>mutant</type>\r\n  <friends type=\"Hash\">\r\n    <i>5</i>\r\n    <Park.Animal>\r\n      <type>dog</type>\r\n    </Park.Animal>\r\n  </friends>\r\n</Park.Animal>\r\n}\r\n\r\nBenchmark.ips do |x|\r\n  x.report('load') { Ox.load(xml, mode: :generic) }\r\nend\r\n```","shortMessageHtmlLink":"Optimize parsing option args in load (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1698744431\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/342\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/342/hovercard\" href=\"https://github.com/ohler55/ox/pull/342\">#342</a>)"}},{"before":"e551b61c9a69f3fa9850b4dbcb64bac265bf43e0","after":"09d4dde9f6a758cee89505d8457c6730806b27f9","ref":"refs/heads/develop","pushedAt":"2023-05-06T23:34:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Use rb_String() instead of rb_funcall() (#341)\n\nrb_String() will convert to String object using #to_s method if needed.\r\n\r\nhttps://github.com/ruby/ruby/blob/8b2884c0b51e4733c09ecbb388ca1b236bad738b/object.c#L3825-L3831","shortMessageHtmlLink":"Use rb_String() instead of rb_funcall() (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1698661114\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/341\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/341/hovercard\" href=\"https://github.com/ohler55/ox/pull/341\">#341</a>)"}},{"before":"e0dca2ed8ea189b5c7ca4d803901160a21ac8182","after":"e551b61c9a69f3fa9850b4dbcb64bac265bf43e0","ref":"refs/heads/develop","pushedAt":"2023-05-06T13:27:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Remove unnecessary check for T_COMPLEX, T_RATIONAL and RB_GC_GUARD (#340)\n\n* Remove unnecessary check for T_COMPLEX and T_RATIONAL\r\n\r\nT_COMPLEX and T_RATIONAL were introduced at Ruby 1.9.0\r\nhttps://github.com/ruby/ruby/commit/6125552c27b40a8da9e162af2655feca82ac16d3\r\n\r\n* Remove unnecessary check for RB_GC_GUARD\r\n\r\nRB_GC_GUARD was introduced at Ruby 1.9.0\r\nhttps://github.com/ruby/ruby/commit/46603a78afde1386f92b38f9b16ca86daa93ad88","shortMessageHtmlLink":"Remove unnecessary check for T_COMPLEX, T_RATIONAL and RB_GC_GUARD (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1698627730\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/340\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/340/hovercard\" href=\"https://github.com/ohler55/ox/pull/340\">#340</a>"}},{"before":"4b276395595416336a9a7cc8463d98f7ac295b9e","after":"e0dca2ed8ea189b5c7ca4d803901160a21ac8182","ref":"refs/heads/develop","pushedAt":"2023-05-06T12:33:04.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Use rb_str_intern() to get symbol instead of rb_funcall() (#339)\n\nThere is an API to get a Symbol object from a String object.\r\n\r\nThe same API is eventually called with rb_funcall(), but it might have some overhead.\r\nhttps://github.com/ruby/ruby/blob/master/string.c#L11988","shortMessageHtmlLink":"Use rb_str_intern() to get symbol instead of rb_funcall() (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1698516943\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/339\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/339/hovercard\" href=\"https://github.com/ohler55/ox/pull/339\">#339</a>)"}},{"before":"08a4a8348442bf8c46f81551571c889e4b5358eb","after":"4b276395595416336a9a7cc8463d98f7ac295b9e","ref":"refs/heads/develop","pushedAt":"2023-05-06T12:31:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Clean up RUBY_INTEGER_UNIFICATION (#338)\n\nRUBY_INTEGER_UNIFICATION was introduced at Ruby 2.4.0.\r\nhttps://github.com/ruby/ruby/blob/8c6b349805e2f17a57576b8dfad31e5681d6b0e9/doc/NEWS/NEWS-2.4.0#compatibility-issues-excluding-feature-bug-fixes-\r\n\r\nNow, ox gem supports Ruby 2.7.0 or later.\r\n\r\nSo, this patch will remove unnecessary code for old Ruby.","shortMessageHtmlLink":"Clean up RUBY_INTEGER_UNIFICATION (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1697246691\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/338\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/338/hovercard\" href=\"https://github.com/ohler55/ox/pull/338\">#338</a>)"}},{"before":"52ff373b759fcf7bc95a09163139f8fdd21c2a26","after":"08a4a8348442bf8c46f81551571c889e4b5358eb","ref":"refs/heads/develop","pushedAt":"2023-05-04T14:56:07.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ohler55","name":"Peter Ohler","path":"/ohler55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/118856?s=80&v=4"},"commit":{"message":"Clean up by removing CRuby API checks that are no longer needed (#337)\n\n* Remove check for rb_obj_encoding\r\n\r\nBecause rb_obj_encoding() was introduced at Ruby 1.9.0\r\nhttps://github.com/ruby/ruby/commit/19dee8af57634c5813286ffbb63cc82611748378\r\n\r\n* Remove check for rb_struct_alloc_noinit\r\n\r\nBecause rb_struct_alloc_noinit() was introduced at Ruby 1.9.0\r\nhttps://github.com/ruby/ruby/commit/0d8956725284206788bae5fbd6ed032f186ad366\r\n\r\n* Remove check for rb_ivar_foreach\r\n\r\nBecause rb_ivar_foreach() was introduced at Ruby 1.9.0\r\nhttps://github.com/ruby/ruby/commit/5c0e68c39c3fc7717311826549a30d1615eb2007\r\n\r\n* Remove check for rb_time_timespec\r\n\r\nBecause rb_time_timespec() was introduced at Ruby 2.3.0\r\nhttps://github.com/ruby/ruby/commit/f1df08e76deadd8a22dc53b86d68cad5f6c11c22\r\n\r\n* Remove check for rb_time_nano_new\r\n\r\nBecause rb_time_nano_new() was introduced at Ruby 1.9.0\r\nhttps://github.com/ruby/ruby/commit/a070c4fbe3cff184d224d1abb8a3101e3c11fc48","shortMessageHtmlLink":"Clean up by removing CRuby API checks that are no longer needed (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1695986946\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ohler55/ox/issues/337\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ohler55/ox/pull/337/hovercard\" href=\"https://github.com/ohler55/ox/pull/337\">#337</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEqgWuPgA","startCursor":null,"endCursor":null}},"title":"Activity · ohler55/ox"}