You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@m90 Great! Quick question: there is quite a bit of similar code for the different types of storages. Would you be open to generalize the code a bit? In a OOP language I would create a common abstract class with with abstract functions like listFiles, uploadFile, removeFile, and so on. Then it's simply a matter of implementing each storage in its own class. This would allow, for instance, to have a single purge function. I'm guessing the go equivalent would be something similar to this.
I know that it's a bit out of scope for this issue, but I'd like to hear your thoughts on this. Also, there to consider the possibility that a single storage jack-of-all-trades like rclone will be the way to go in the future (as per #65); in this case abstracting the current storages like this will probably be a waste of time.
@m90 Great! Quick question: there is quite a bit of similar code for the different types of storages. Would you be open to generalize the code a bit? In a OOP language I would create a common abstract class with with abstract functions like
listFiles
,uploadFile
,removeFile
, and so on. Then it's simply a matter of implementing each storage in its own class. This would allow, for instance, to have a singlepurge
function. I'm guessing the go equivalent would be something similar to this.I know that it's a bit out of scope for this issue, but I'd like to hear your thoughts on this. Also, there to consider the possibility that a single storage jack-of-all-trades like rclone will be the way to go in the future (as per #65); in this case abstracting the current storages like this will probably be a waste of time.
Originally posted by @MMauro94 in #94 (comment)
The text was updated successfully, but these errors were encountered: