[IMP] pos: update content of the pricelists page #5688

LoredanaLrpz · 2023-08-30T14:34:00Z

task-3005170

robodoo · 2023-08-30T14:34:40Z

auva-odoo

Hey @LoredanaLrpz Thank you for writing this, you did a great job :-) I have a few suggestions and a few questions (sorry!), let me know when you're ready to discuss them!

content/applications/sales/point_of_sale/pricing/pricelists.rst

auva-odoo · 2023-09-06T07:39:17Z

content/applications/sales/point_of_sale/pricing/pricelists.rst

+You can also set a pricelist to be selected automatically once a specific :ref:`customer is set
+<pos/customers>`. To do so, go to the customer form and switch to the preferred pricelist on the
+:guilabel:`Pricelist` field of the :guilabel:`Sales & Purchase` tab.


Suggested change

You can also set a pricelist to be selected automatically once a specific :ref:`customer is set

<pos/customers>`. To do so, go to the customer form and switch to the preferred pricelist on the

:guilabel:`Pricelist` field of the :guilabel:`Sales & Purchase` tab.

You can also set a pricelist to be selected automatically once a specific :ref:`customer is set

<pos/customers>`. To do so, go to the customer form and select the preferred pricelist in the

:guilabel:`Pricelist` field of the :guilabel:`Sales & Purchase` tab.

I would maybe also mention that you need to click Edit, but that's probably me

I left "switch" because I use "select" a lot =)
Also, in v15, you can click the field name to switch to edit mode

content/applications/sales/point_of_sale/pricing/pricelists.rst

LoredanaLrpz

@auva-odoo : I've made most changes and I'm available to discuss what I didn't understand :)

content/applications/sales/point_of_sale/pricing/pricelists.rst

LoredanaLrpz · 2023-09-08T14:19:58Z

content/applications/sales/point_of_sale/pricing/pricelists.rst

+You can also set a pricelist to be selected automatically once a specific :ref:`customer is set
+<pos/customers>`. To do so, go to the customer form and switch to the preferred pricelist on the
+:guilabel:`Pricelist` field of the :guilabel:`Sales & Purchase` tab.


I left "switch" because I use "select" a lot =)
Also, in v15, you can click the field name to switch to edit mode

jcs-odoo

Hello @LoredanaLrpz and @auva-odoo

Superrrr great work from both of you! Clean PR and review👌Thanks!

I wanted to address my comments immediately but I don't have the time right now. Maybe on Monday. But anyway:

@robodoo delegate+

Cheers :)

jcs-odoo · 2023-09-22T09:31:00Z

content/applications/sales/point_of_sale/pricing/pricelists.rst

+Click :guilabel:`Create` or select an existing pricelist. The pricelist setup form differs depending
+on the chosen type of pricelist.
+
+.. tabs::


It certainly is!
But it reminds me that tabs' titles are still not translatable, sadly.

There is an issue about this: executablebooks/sphinx-tabs#137
but it seems stalled.

jcs-odoo · 2023-09-22T14:33:06Z

content/applications/sales/point_of_sale/pricing/pricelists.rst

+           - Define what the calculation is based on (the :guilabel:`Sales Price`, the
+             :guilabel:`Cost`, or an :guilabel:`Other Pricelist`.)


"an Other Pricelist" reads weirdly, maybe like this?

Suggested change

- Define what the calculation is based on (the :guilabel:`Sales Price`, the

:guilabel:`Cost`, or an :guilabel:`Other Pricelist`.)

- Define what the calculation is based on (:guilabel:`Sales Price`,

:guilabel:`Cost`, or :guilabel:`Other Pricelist`.)

jcs-odoo · 2023-09-22T14:39:43Z

content/applications/sales/point_of_sale/pricing/pricelists.rst

+Then, select the :ref:`type of pricelist <pricelists/create>` by checking :guilabel:`Multiple prices
+per product` or :guilabel:`Advanced price rules (discounts, formulas)`, save, and click
+:guilabel:`Pricelists` to create new ones or modify existing ones.


I agree with @auva-odoo 's comment to better explain the difference between the two types (multiple / advanced rules), or maybe add an example section?

I wanted to do it but I'm afraid I have to leave, so we'll see on Monday morning :)

task-3005170

xpl-odoo · 2023-10-12T07:18:42Z

@robodoo r+

task-3005170 closes #5688 Signed-off-by: Xavier Platteau (xpl) <[email protected]>

robodoo · 2023-10-12T07:55:27Z

@LoredanaLrpz @xpl-odoo staging failed: ci/runbot on 436bdd30820f03714d954d7f07eaeb552e9043c4 (view more at https://runbot.odoo.com/runbot/build/52286015)

xpl-odoo · 2023-10-12T11:11:53Z

@robodoo retry

task-3005170 closes #5688 Signed-off-by: Xavier Platteau (xpl) <[email protected]>

fw-bot · 2023-10-16T05:55:06Z

@LoredanaLrpz @xpl-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][IMP] pos: update content of the pricelists page #6117

fw-bot · 2023-10-17T05:54:49Z

@LoredanaLrpz @xpl-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][IMP] pos: update content of the pricelists page #6117

fw-bot · 2023-10-18T05:54:21Z

@LoredanaLrpz @xpl-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

LoredanaLrpz force-pushed the 15.0-pos-pricelists-lrpz branch 2 times, most recently from a387801 to 524393f Compare September 4, 2023 07:53

LoredanaLrpz marked this pull request as ready for review September 4, 2023 07:57

C3POdoo requested review from a team September 4, 2023 07:58

auva-odoo requested changes Sep 6, 2023

View reviewed changes

LoredanaLrpz force-pushed the 15.0-pos-pricelists-lrpz branch from 524393f to 1c7d72b Compare September 8, 2023 14:21

LoredanaLrpz commented Sep 8, 2023

View reviewed changes

LoredanaLrpz force-pushed the 15.0-pos-pricelists-lrpz branch from 1c7d72b to f930faa Compare September 12, 2023 11:28

LoredanaLrpz requested a review from auva-odoo September 12, 2023 11:28

auva-odoo approved these changes Sep 12, 2023

View reviewed changes

auva-odoo requested a review from a team September 12, 2023 11:43

jcs-odoo approved these changes Sep 22, 2023

View reviewed changes

[IMP] pos: update content of the pricelists page

ae96b4f

task-3005170

xpl-odoo force-pushed the 15.0-pos-pricelists-lrpz branch from f930faa to ae96b4f Compare October 4, 2023 16:06

robodoo pushed a commit that referenced this pull request Oct 12, 2023

[IMP] pos: update content of the pricelists page

202928c

task-3005170 closes #5688 Signed-off-by: Xavier Platteau (xpl) <[email protected]>

odoo deleted a comment from robodoo Oct 12, 2023

robodoo pushed a commit that referenced this pull request Oct 12, 2023

[IMP] pos: update content of the pricelists page

78a26a0

task-3005170 closes #5688 Signed-off-by: Xavier Platteau (xpl) <[email protected]>

robodoo temporarily deployed to merge October 12, 2023 12:59 Inactive

robodoo closed this Oct 12, 2023

This was referenced Oct 12, 2023

[FW][IMP] pos: update content of the pricelists page #6116

Closed

[FW][IMP] pos: update content of the pricelists page #6117

Closed

This was referenced Oct 17, 2023

[FW][IMP] pos: update content of the pricelists page #6157

Closed

[FW][IMP] pos: update content of the pricelists page #6158

Closed

This was referenced Oct 17, 2023

[FW][IMP] pos: update content of the pricelists page #6159

Closed

[FW][IMP] pos: update content of the pricelists page #6160

Closed

[FW][IMP] pos: update content of the pricelists page #6161

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] pos: update content of the pricelists page #5688

[IMP] pos: update content of the pricelists page #5688

LoredanaLrpz commented Aug 30, 2023

robodoo commented Aug 30, 2023

auva-odoo left a comment

auva-odoo Sep 6, 2023

LoredanaLrpz Sep 8, 2023

LoredanaLrpz left a comment •

edited

Loading

LoredanaLrpz Sep 8, 2023

jcs-odoo left a comment

jcs-odoo Sep 22, 2023

jcs-odoo Sep 22, 2023

jcs-odoo Sep 22, 2023

xpl-odoo commented Oct 12, 2023

robodoo commented Oct 12, 2023

xpl-odoo commented Oct 12, 2023

fw-bot commented Oct 16, 2023

fw-bot commented Oct 17, 2023

fw-bot commented Oct 18, 2023

		- Define what the calculation is based on (the :guilabel:`Sales Price`, the
		:guilabel:`Cost`, or an :guilabel:`Other Pricelist`.)

[IMP] pos: update content of the pricelists page #5688

[IMP] pos: update content of the pricelists page #5688

Conversation

LoredanaLrpz commented Aug 30, 2023

robodoo commented Aug 30, 2023

auva-odoo left a comment

Choose a reason for hiding this comment

auva-odoo Sep 6, 2023

Choose a reason for hiding this comment

LoredanaLrpz Sep 8, 2023

Choose a reason for hiding this comment

LoredanaLrpz left a comment • edited Loading

Choose a reason for hiding this comment

LoredanaLrpz Sep 8, 2023

Choose a reason for hiding this comment

jcs-odoo left a comment

Choose a reason for hiding this comment

jcs-odoo Sep 22, 2023

Choose a reason for hiding this comment

jcs-odoo Sep 22, 2023

Choose a reason for hiding this comment

jcs-odoo Sep 22, 2023

Choose a reason for hiding this comment

xpl-odoo commented Oct 12, 2023

robodoo commented Oct 12, 2023

xpl-odoo commented Oct 12, 2023

fw-bot commented Oct 16, 2023

fw-bot commented Oct 17, 2023

fw-bot commented Oct 18, 2023

LoredanaLrpz left a comment •

edited

Loading