[IMP] theme_*: POC website design in db #766
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a walking skeleton of the website design in db. task-2463604
Guillaume-gdi
force-pushed
the
master-website-design-in-db-gdi
branch
from
0b0de9c
to
c57449e
Compare
qsm-odoo
requested changes
Feb 10, 2024
| @@ -177,7 +177,6 @@ $o-theme-font-configs: ( | |||
| $o-website-values-palettes: ( | |||
| ( | |||
| 'color-palettes-name': 'avantgarde-3', | |||
| 'layout': 'full', | |||
There was a problem hiding this comment.
Don't hesitate to make extra PR that I can merge directly for things like these: defining layout = full in a theme is useless since this is a default (this is not wrong but I'd say it is best not to write it if useless).
If I can merge small stuff like these that are independent of your work directly, it will make the review easier later 👍
|
|
||
| <record id="theme_graphene.design" model="theme.website.design"> | ||
| <field name="layout">'boxed'</field> | ||
| <field name="theme_id" ref="base.module_theme_graphene"/> |
There was a problem hiding this comment.
You are actually filling the "theme.utils" many2one with a "ir.module.module" record, funny if it works ^^ Anyways, like I said in the other PR: you don't need that. You are in theme_graphene, you should never have to say "I am a theme_graphene record".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a walking skeleton of the website design in db.
task-2463604