Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runner group access return type #2965

Merged

Conversation

MatisseHack
Copy link
Contributor

Resolves #2964


Before the change?

  • Runner group access APIs would return empty objects because they weren't wrapped in a response object

After the change?

  • Runner group access APIs return properly deserialized responses

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

I didn't see existing tests for deserialization, but I'm happy to add tests if there is an established pattern to follow.

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

The return type of several functions changed (although these functions would have returned empty objects before)


Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kfcampbell kfcampbell merged commit 160a723 into octokit:main Aug 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Runner group access APIs return empty objects
2 participants