Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Search box above section list #277

Open
rajubeparybd opened this issue Mar 15, 2023 · 2 comments
Open

Feature Request: Search box above section list #277

rajubeparybd opened this issue Mar 15, 2023 · 2 comments

Comments

@rajubeparybd
Copy link

When ever need any section its need to go through all the section if the required section stay in bottom. If a search functionality can implement of sections, it will be very helpful. Thanks.

image
@ksaswin
Copy link
Contributor

ksaswin commented Apr 4, 2023

@octokatherine Could you kindly assign this issue to me?

Thanks😊

ksaswin added a commit to ksaswin/readme.so that referenced this issue Apr 4, 2023
@ksaswin
Feature Request: Search box above section list octokatherine#277
264a6ac 
Add new SectionFilter component to filter slugs based on section names
Update SectionsColumn to display filtered sections
Add units tests for SectionFilter component
@ksaswin ksaswin mentioned this issue Apr 4, 2023
Merged
@ksaswin
Copy link
Contributor

ksaswin commented Apr 13, 2023

Hi @rajubeparybd @octokatherine,

I have opened a PR for the feature requested here. Link to the pull request #278
Let me know if I'm headed in the right direction and would love to hear your feedback on it.

octokatherine pushed a commit that referenced this issue Jul 23, 2023
@ksaswin
Feature Request: Search box above section list #277 (#278)
ff1e825 
* Feature Request: Search box above section list #277

Add new SectionFilter component to filter slugs based on section names
Update SectionsColumn to display filtered sections
Add units tests for SectionFilter component

* Update filteredSlugs state on add action

* Trim section query string before filtering with it

* Move sections filter above custom section

* Improve search filter UX

Remove search input after selecting a section
Move search filter logic to SectionsColumn component
Update SectionFilter unit test

* Remove unused filterSections function

* Fix resetSearchFilter function call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksaswin @rajubeparybd