Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graffiti : Color and size of the brush use deprecated widget #72

Open
cedlemo opened this issue May 17, 2017 · 3 comments
Open

Graffiti : Color and size of the brush use deprecated widget #72

cedlemo opened this issue May 17, 2017 · 3 comments

Comments

@cedlemo
Copy link
Contributor

cedlemo commented May 17, 2017 •
edited
Loading

In the Graffiti tutorial, the part Color and size of the brush is based on the ocsigen-widgets which are deprecated. The README of the repo links to ocsigen-toolkit.

Is there a color picker widget in ocsigen-toolkit ?
@vasilisp
Copy link
Contributor

Is there a color picker widget in ocsigen-toolkit ?

Not at this time. I guess we wouldn't mind adding one, as long as it matches the coding and API style of the other Ocsigen Toolkit widgets. Contributions welcome :).

@cedlemo
Copy link
Contributor Author

cedlemo commented May 17, 2017

Contributions welcome

Oh great, it interests me, I will give it a try.

@cedlemo
Copy link
Contributor Author

cedlemo commented May 23, 2017

@vasilisp ,

I created an issue because I was able to add the color picker from ocsigen-widgets to ocsigen-toolkit but before doing the Pull Request, I wanted to know if I should change something.

Sorry to bother if you saw the issue I created but you did not have time to answer me.

@cedlemo cedlemo mentioned this issue May 24, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cedlemo @vasilisp