New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use `Object.is` instead of `===` to implement phys_equal #1372

Open

TyOverby opened this issue Dec 30, 2022 · 0 comments · May be fixed by #1410

Labels

Collaborator

TyOverby commented Dec 30, 2022

There are a few places where the behavior of phys_equal differ between native OCaml and Jsoo:

a	b	native	jsoo
NaN	NaN	true	false
0.0	-0.0	false	true

The (relatively) new Object.is function implements those comparisons "correctly":
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is

The text was updated successfully, but these errors were encountered:

TyOverby added the enhancement label

hhugo linked a pull request

that will close this issue

WIP: Sameness #1410

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment