Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of java.time's ChronoUnit, Duration and Period. #247

Open
Isira-Seneviratne opened this issue Oct 31, 2022 · 1 comment
Open

Make use of java.time's ChronoUnit, Duration and Period. #247

Isira-Seneviratne opened this issue Oct 31, 2022 · 1 comment

Comments

@Isira-Seneviratne
Copy link
Contributor

Isira-Seneviratne commented Oct 31, 2022 •
edited
Loading

The PrettyTime codebase could be refactored to make use of the ChronoUnit enum and Duration and Period classes, instead of defining the current implementations manually.
@Isira-Seneviratne Isira-Seneviratne changed the title Make use of java.time's ChronoUnit and Duration. Make use of java.time's ChronoUnit, Duration and Period. Oct 31, 2022
@lincolnthree
Copy link
Member

Hi @Isira-Seneviratne thanks for the issue. Please feel free to submit a PR with these improvements, and thank you for pointing out the new APIs! I do think it would be a good idea to standardize on these.

@Isira-Seneviratne Isira-Seneviratne mentioned this issue Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lincolnthree @Isira-Seneviratne