Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

space between characters for Chinese locales #217

Open
linama opened this issue May 11, 2021 · 1 comment
Open

space between characters for Chinese locales #217

linama opened this issue May 11, 2021 · 1 comment

Comments

@linama
Copy link

linama commented May 11, 2021

Hi, we are testing out your lib to support the needs to get localized strings. Your lib fits our needs but noticed that for Chinese locales(zh_), there are spaces between characters. For example, 1 天 前, 3 小时 前, or 59 分鐘 前. Shouldn't they be 1天前, 3小时前, or 59分鐘前 ? Thank you for your time.

@lincolnthree
Copy link
Member

lincolnthree commented May 13, 2021

@linama Thanks for reporting the issue. I am not an expert in the Chinese language. You'd have to ask the original author of that resource bundle/language pack (陈正华), but I no longer have their contact information. It sounds like the zh_ bundles may need to have their patterns updated. Pull requests welcome to fix the issue:

https://github.com/ocpsoft/prettytime/blob/master/core/src/main/java/org/ocpsoft/prettytime/i18n/Resources_zh.java#L31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants