Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrettyTimeConverter: missing annotation #216

Open
flange-ipb opened this issue Apr 21, 2021 · 3 comments
Open

PrettyTimeConverter: missing annotation #216

flange-ipb opened this issue Apr 21, 2021 · 3 comments

Comments

@flange-ipb
Copy link

Hi folks!

Just a tiny issue: You can annotate the PrettyTimeConverter class with @FacesConverter("prettyTimeConverter"). Without this, the example on the web page does not work.

Thanks,
Frank

@lincolnthree
Copy link
Member

lincolnthree commented Apr 24, 2021

Hey Frank!

Thanks for pointing this out.
Could you give more details of where you're seeing or not seeing this info? Would love to fix it but need some more context.

Appreciated,
Lincoln

The converter should be registered by the bundled faces-config.xml

@tomekkup
Copy link

UP !
Additionaly PrettyTimeConverter does not support Java 8 JDK DateTime API

@lincolnthree
Copy link
Member

Hey @flange-ipb and @tomekkup - Thanks for the issue. Please send a test case that reproduces the issue and feel free to submit a PR/fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants