Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Branch] fix(UI): The form verification border should be marked red normally. #628

Open
wants to merge 12 commits into
base: feature
Choose a base branch
from
Open

[Feature Branch] fix(UI): The form verification border should be marked red normally. #628

wants to merge 12 commits into from

Conversation

linhf123
Copy link
Collaborator

@linhf123 linhf123 commented Jul 9, 2024 •
edited
Loading

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add form validation error border color
🇨🇳 Chinese 添加 form 校验错误边框色

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

@linhf123 linhf123 changed the base branch from master to feature July 9, 2024 09:37
@linhf123 linhf123 changed the title 【WIP】fix(UI): The form verification border should be marked red normally. fix(UI): The form verification border should be marked red normally. Aug 12, 2024
@dengfuping
Copy link
Collaborator

有效果截图吗？

@linhf123
Copy link
Collaborator Author

linhf123 commented Sep 5, 2024

有效果截图吗？

有的 我稍后补点

@dengfuping dengfuping changed the title fix(UI): The form verification border should be marked red normally. [Feature Branch] fix(UI): The form verification border should be marked red normally. Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dengfuping dengfuping Awaiting requested review from dengfuping

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix @oceanbase/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linhf123 @dengfuping