Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] deprecate batch interface setIsAtomic and modify releated test cases #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GroundWu
Copy link
Contributor

@GroundWu GroundWu commented Dec 4, 2023

Summary

Deprecate the batch setIsAtomic interface and the batch operation is atomic now. Atomic means:
If one of the operation in a single-partition batch request execute failed, it will rollback and return error code.

Solution Description

  • Deprecate the batch setIsAtomic interface
  • Modify atomic-related test case

@IHEII
Copy link
Contributor

IHEII commented Dec 4, 2023

Let us modify the demo and readme to indicate to users that we can't ensure atomicity when they are using batch operation across tablets/partitions.

@GroundWu
Copy link
Contributor Author

GroundWu commented Dec 4, 2023

Let us modify the demo and readme to indicate to users that we can't ensure atomicity when they are using batch operation across tablets/partitions.

Across partitions is not supported when use batch operation, and it will throw ObTablePartitionConsistentException when user do that. Add demo and readme in following files:

  • example/simple-table-demo/README.md
  • example/simple-table-demo/src/main/java/com/oceanbase/example/SimpleTableDemo.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants