-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples for the paper #1
Comments
I can provide a filtering example of along-track absolute dynamic topography and/or cross-track geostrophic velocity. I had imagined a figure like this (below). The upper panel shows one cycle of ADT filtered using the boxcar, Gaussian, and sharp filters. The lower panel shows the mean cross-term (u_bar*u_prime) magnitude averaged over ~50 cycles along the same track. Specifics are easy to change. I can also provide an example applying 2d filtering (as I believe Nora is) to surface geostrophic kinetic energy from gridded AVISO. |
I shared a bit of my POP code here: ocean-eddy-cpt/gcm-filters#14 @iangrooms - could you point me to a path on glade where some POP 0.1-degree output lives? I'll try to plug them together. |
The POP data is in /home/bryan/johnsonb/ on cheyenne. Once you unzip a single 5-day average, it's about a 90GB netcdf file. If I recall correctly, the data starts after a 15 year spinup using CORE-2 normal-year forcing, so you should be fine to start with year 0 if you want. |
Actually it's on HPSS at /home/bryan/johnsonb, see documentation here https://www2.cisl.ucar.edu/resources/storage-and-file-systems/hpss/managing-files-hsi for how to get it. |
@jakesteinberg that figure looks great to me! |
@rabernat If you want to avoid HPSS I have one data volume on cheyenne at /glade/work/igrooms/current_data. current_data is a netcdf file |
I have done 1.-3. for the NeverWorld2 MOM6 lat/lon grid, so it should be straightforward for me to reproduce these figures for the POP data, with help of @rabernat's POP kernels/code examples. I was first thinking about trying 1.-3. for the MITgcm LLC4320 data using xmitgcm's wrappers to handle the different faces, but the POP data seems easier to work with. |
LLC-type grids will be very difficult to deal with using this method because they require exchange between the cube faces. This is not something that xgcm supports today. Even if it did, it would not work on the GPU. |
@iangrooms - what about including an example of thickness-weighted filtering in an isopycnal-coordinate model? |
I think we should skip thickness-weighted since we don't want to scoop other parts of the CPT work and also since it doesn't really seem to illustrate any particular point about how these filters work. (Unless I missed something.) |
Ok. The main motivation would be to highlight that the sharp filter has limited use if you want to preserve the volume integral when filtering in an isopycnal coordinate model (via thickness-weighted filtering, |
This is an amazing figure @jakesteinberg! |
@NoraLoose we should definitely show the problem with negative values somehow. One way is just to show that the filter can produce values outside (eps. below) of the range of the data, so we might be able to make that point with temperature or salinity even if we don't produce negative temperature or salinity. It might be useful to show that mean(square) - square(mean) is not necessarily positive when the weights are negative. Maybe we could do that with @jakesteinberg's along-track data? Does the sharp filter produce negative "EKE" in your along-track data? |
@iangrooms, I posted a figure in this comment that shows all locations where the taper filter generates negative values for EKE. Negative EKE is ubiquitous! |
I'm wondering if we should also compare how the different filters interact with the two definitions of variance. Nora's EKE example shows how the taper filter produces lots of negative EKE under the definition |
I had a useful call with Nora and Scott this morning where we took stock of the status and what needs to be done for the examples section of the paper.
For all of the figures we'll need background on where the data came from, and where it can be accessed. If it's not already public then (assuming it's not too large) we can put it on figshare, or somewhere else (TBD). Once all the figures for the example section are ready I can write up the text for section 3 of the paper. |
Attached is the figure from #18 |
Thanks @ElizabethYankovsky! This figure looks good to me. We might have to edit later if co-authors or reviewers want, but for now I think this is good. I updated my post above with the list of figures to reflect that this one is done. |
I've added all the figures you provided to the draft on overleaf. Almost everything has a paragraph or two describing it (excepting along-track SLA, which I hope to get to soon). I would be grateful if you could go on overleaf and provide a sentence or two about where the data came from. Specifically:
Also please correct any mistakes I might have made in describing the figures. I think the "examples" section is almost complete. |
@iangrooms I've added a description of Figure 6 as well as text and references on CM2.6/MOM5. Please see line 765 in the overleaf document. I wasn't sure what you meant with the Pangeo reference, so I included both text and a citation (feel free to remove either). |
Looks great! The only change I made is to replace 1/10 degrees by 0.1 degrees, not because it's wrong but just for consistency. For the pangeo reference I just wanted to make sure you'd cite more than just the pangeo url for the data, so your current version is perfect. Thanks! |
Here's a list of ideas for examples to include in the paper. Please add and discuss
The text was updated successfully, but these errors were encountered: