You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the linter underlines the entire module implementation when there is any mismatch in signature. This is problematic because (a) it makes it visually very hard to read what's going and (b) it overrides any other linting errors in the module. Take the following example:
0: moduleA : sig1: type t
2: end=struct3: type t = { field: InvalidSyntax }
4: end
Normally, one would expect InvalidSyntax to be underined on line 3. But here, the invalid syntax causes OCaml Platform not to know of any defined type t, therefore causing a module signature mismatch. As a result, everything from struct on line 2 to end on line 4 is underlined in red, and you can't see the specific underline under InvalidSyntax.
Thus, it would be helpful if the underline for module signature mismatch was much smaller--perhaps only on the struct keyword.
The text was updated successfully, but these errors were encountered:
Currently, the linter underlines the entire module implementation when there is any mismatch in signature. This is problematic because (a) it makes it visually very hard to read what's going and (b) it overrides any other linting errors in the module. Take the following example:
Normally, one would expect
InvalidSyntax
to be underined on line 3. But here, the invalid syntax causes OCaml Platform not to know of any defined typet
, therefore causing a module signature mismatch. As a result, everything fromstruct
on line 2 toend
on line 4 is underlined in red, and you can't see the specific underline underInvalidSyntax
.Thus, it would be helpful if the underline for module signature mismatch was much smaller--perhaps only on the struct keyword.
The text was updated successfully, but these errors were encountered: