-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download and install tailwindcss binary without opam #2718
Conversation
Generally in favor, but can you expand on the benefits you see here?
|
One potential benefit is outside ocaml.org, not storing binaries in https://github.com/tmattio/opam-tailwindcss. @MisterDA shared his concern about it. But mostly, this is proof-of-concept code, I needed it whilst developing branch
I wasn't aware this existed. You're right; it's better.
Update: Fixed |
There's a curl shipped by Microsoft since Windows 10. |
BTW, has anybody ever tried to compile ocaml.org in Windows? This PR's |
Could these Dune rules be packaged in the |
There's already an unused |
Dune has support for fetching files but it is not part of the action language and under the hood it also uses and requires |
Ok, I'm convinced with the approach, thanks for the PR @cuihtlauac! I've pushed a commit to simplify things slightly (I don't think we need to put the URL and version in separate files), but I'll merge now. For some reason Dune package management was failing when installing opam-tailwindcss (cc @Leonidas-from-XIV might be an unknown issue?), so this brings back support for dune pkg. |
Happy to have convinced you. Did you intentionally or accidentally remove the |
It was intentional, I commented on the other PR: I'm not sure how the alias helps to download only one binary. Can you expand on this? |
dune-project
andocamlorg.opam
dune-workspace
andocamlorg.opam.template
tools/tailwindcss/dune
thattailwindcss
binary fromtailwindlabs/tailwindcss
Remark: files
tools/tailwindcss/URL
andtools/tailwindcss/RELEASE
must not have end of line characters.