Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated book page for individual books #1726

Closed
wants to merge 3 commits into from

Conversation

Oluwabukolab
Copy link
Contributor

Fixes #1640. Still a draft

Created an individual page for each book on the books page. I'm still working on it but wanted to be sure I'm the right path. cc @SaySayo @sabine

@gpetiot gpetiot added the outreachy Outreachy contributions and blog posts label Oct 31, 2023
@sabine
Copy link
Collaborator

sabine commented Nov 1, 2023

Hey @sophiatunji, you're on the right path, but the template will have to take a parameter (book : Data.Book.t)

@Oluwabukolab
Copy link
Contributor Author

Oluwabukolab commented Nov 9, 2023

I've successfully created an individual page for each book entry and I added it to the learn home page so each book can be clicked to link to it. I have a few questions on how the page is meant to look. Do we want it to be displayed exactly like each book is on the books page like this screenshot? or is there a proposed design in mind? cc @sabine @SaySayo
Screenshot 2023-11-09 at 10 23 08

Also, I tried linking each book in the books page too but I'm unsure where it's meant to click from, I currently encompass the entire book entry into an a tag, but that just highlights the entire text as a link.
Screenshot 2023-11-09 at 10 26 11

@sabine
Copy link
Collaborator

sabine commented Nov 9, 2023

@sophiatunji great progress!

Do we want it to be displayed exactly like each book is on the books page like this screenshot? or

Yes, I think that would be best, just repeating the design from the books.eml template seems fine here.

Also, I tried linking each book in the books page too but I'm unsure where it's meant to click from

I think we don't want to link to the individual books page from the books page because all information is already laid out on the books page.

The only reason why we need an individual book page is because the Learn landing page links to some books, and we would like to give people the info just about that single book. The alternative to having a dedicated page for each book would be to have a way to link into the books page such that we land at the exact book referenced.

@sabine
Copy link
Collaborator

sabine commented Nov 27, 2023

@sophiatunji do you plan to continue on this?

@Oluwabukolab
Copy link
Contributor Author

Hi @sabine, yes I do plan to complete this PR, my apologies about the delay.

@sabine
Copy link
Collaborator

sabine commented Dec 6, 2023

Hello @sophiatunji, I think adding a dedicated page for every book became obsolete with the new design that includes the external links directly in the book blocks. See #1834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Outreachy contributions and blog posts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants