-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedicated book page for individual books #1726
Conversation
Hey @sophiatunji, you're on the right path, but the template will have to take a parameter |
I've successfully created an individual page for each book entry and I added it to the learn home page so each book can be clicked to link to it. I have a few questions on how the page is meant to look. Do we want it to be displayed exactly like each book is on the books page like this screenshot? or is there a proposed design in mind? cc @sabine @SaySayo Also, I tried linking each book in the books page too but I'm unsure where it's meant to click from, I currently encompass the entire book entry into an |
@sophiatunji great progress!
Yes, I think that would be best, just repeating the design from the
I think we don't want to link to the individual books page from the books page because all information is already laid out on the books page. The only reason why we need an individual book page is because the Learn landing page links to some books, and we would like to give people the info just about that single book. The alternative to having a dedicated page for each book would be to have a way to link into the books page such that we land at the exact book referenced. |
@sophiatunji do you plan to continue on this? |
Hi @sabine, yes I do plan to complete this PR, my apologies about the delay. |
d46bbb6
to
5e24486
Compare
Hello @sophiatunji, I think adding a dedicated page for every book became obsolete with the new design that includes the external links directly in the book blocks. See #1834 |
Fixes #1640. Still a draft
Created an individual page for each book on the books page. I'm still working on it but wanted to be sure I'm the right path. cc @SaySayo @sabine