Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Block Component [Learn Area Redesign] #1480

Closed
wants to merge 2 commits into from
Closed

Video Block Component [Learn Area Redesign] #1480

wants to merge 2 commits into from

Conversation

SaySayo
Copy link
Contributor

@SaySayo SaySayo commented Aug 7, 2023

PR for the video block according to learn area redesign.
Screenshot 2023-08-07 at 10 02 17

@sabine
Copy link
Collaborator

sabine commented Aug 7, 2023

  • the video component takes as parameters the video_url, thumbnail_url, title, and description. All of these are provided by the caller in learn.eml.
  • don't use h-, use a grid to make components that are side-by-side same height
  • the padding
  • make it collapse well

@SaySayo SaySayo force-pushed the learn-area-video-components branch from 5f1fecf to 8933258 Compare August 15, 2023 01:06
@sabine sabine added the ui label Sep 5, 2023
@sabine
Copy link
Collaborator

sabine commented Dec 12, 2023

Became obsolete with new Learn UI

@sabine sabine closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SaySayo @sabine