Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: upgrade brr to 0.0.6 to fix URI param hack #1477

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

just-max
Copy link
Contributor

@just-max just-max commented Aug 4, 2023

Follow-up to #1434 (comment) as promised :)

I didn't see any other uses of brr's URI module, so no further changes should be required.

@just-max
Copy link
Contributor Author

CC @sabine: There's no rush, but I wouldn't want it to go under either :>

Copy link
Collaborator

@sabine sabine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @just-max, sorry, we were all mostly on holiday and definitely won't let this one slip. This is really nice!

@sabine sabine merged commit 1c51276 into ocaml:main Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants