-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Manual Banner Component For Learn Area Redesign #1406
Conversation
<div class="container bg-learn-area-orange w-full h-80 flex items-center px-4"> | ||
<div class="w-2/3 pr-4 mb-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
container needs to be inside the surrounding content, and don't use container
, but container-fluid
is probably more appropriate here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is a banner, it probably makes sense to have it be fully clickable
Collapsing on small screens: Image stacked on top of the rest of the content.
cc54f89
to
3007082
Compare
8f47ee7
to
b239bab
Compare
fff9263
to
79a30f1
Compare
Thanks @SaySayo! |
Hi @tmattio, this wasn't meant to be merged yet as there's a bit of a bug in the responsiveness on smaller screens. I should've marked it as a draft. My apologies about the inconvenience. Will send a PR fixing the bug ASAP! |
Co-authored-by: Thibaut Mattio <[email protected]>
Built a component for the language manual banner according to the learn area redesign. cc @sabine
Figma design
Created component