Language Manual Banner Component For Learn Area Redesign #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabine
reviewed
Jul 19, 2023
sabine
reviewed
Jul 25, 2023
Comment on lines
2
to
3
| <div class="container bg-learn-area-orange w-full h-80 flex items-center px-4"> | ||
| <div class="w-2/3 pr-4 mb-2"> |
There was a problem hiding this comment.
container needs to be inside the surrounding content, and don't use container, but container-fluid is probably more appropriate here.
sabine
reviewed
Jul 25, 2023
SaySayo
force-pushed
the
language-manual-component
branch
from
cc54f89
to
3007082
Compare
SaySayo
force-pushed
the
language-manual-component
branch
from
8f47ee7
to
b239bab
Compare
sabine
added a commit
that referenced
this pull request
Sep 7, 2023
SaySayo
force-pushed
the
language-manual-component
branch
from
fff9263
to
79a30f1
Compare
|
Thanks @SaySayo! |
|
Hi @tmattio, this wasn't meant to be merged yet as there's a bit of a bug in the responsiveness on smaller screens. I should've marked it as a draft. My apologies about the inconvenience. Will send a PR fixing the bug ASAP! |
cuihtlauac
pushed a commit
that referenced
this pull request
Oct 3, 2023
cuihtlauac
pushed a commit
that referenced
this pull request
Oct 17, 2023
Co-authored-by: Thibaut Mattio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built a component for the language manual banner according to the learn area redesign. cc @sabine
Figma design
Created component
