Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog entries for OCaml LSP releases #1395

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

tmattio
Copy link
Collaborator

@tmattio tmattio commented Jul 14, 2023

I noticed that we were missing changelog entries for the recent releases of OCaml LSP.

cc @rgrinberg @voodoos - would be great to have these for future releases if possible, with #1394, we'll now link to the OCaml Changelog entries from the newsletter.

@rgrinberg
Copy link
Member

Which entries were missing?

@tmattio
Copy link
Collaborator Author

tmattio commented Jul 17, 2023

For the releases of OCaml LSP 1.16.1 and 1.16.2

@tmattio tmattio merged commit 9636cb5 into main Jul 17, 2023
3 checks passed
@tmattio tmattio deleted the ocaml-lsp-changelog branch July 17, 2023 09:14
@rgrinberg
Copy link
Member

I see them in CHANGES.md:

# 1.16.2

## Fixes

- Fix file permissions used when specifying output files of pp and ppx. (#1153)

# 1.16.1

## Fixes

- Support building with OCaml 5.0 and 5.1 (#1150)

@tmattio
Copy link
Collaborator Author

tmattio commented Jul 17, 2023

I meant entries on the OCaml Changelog, the ones that are being added in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants