Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement textDocument/diagnostic for synchronous update #1327

Open
ddickstein opened this issue Jul 4, 2024 · 3 comments
Open

Implement textDocument/diagnostic for synchronous update #1327

ddickstein opened this issue Jul 4, 2024 · 3 comments

Comments

@ddickstein
Copy link
Collaborator

It would be nice for clients to be able to send a synchronous request and know that when it returns the diagnostics for the buffer are up-to-date.

@rgrinberg
Copy link
Member

rgrinberg commented Jul 4, 2024

What about using "pull diagnostics" to just ask for the diagnostics for a document. That would return all diagnostics and you would know they are up to date.

EDIT: I think that's exactly what you meant

@ddickstein
Copy link
Collaborator Author

ddickstein commented Jul 4, 2024 via email

@rgrinberg
Copy link
Member

The group of requests/notifications defined in 3.17 for a "pull" based model of diagnostics https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_pullDiagnostics

textDocument/diagnostic is a part of that I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants