Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merlin: introduce generate_merlin_rules #10328

Closed

Conversation

jchavarri
Copy link
Collaborator

@jchavarri jchavarri commented Mar 28, 2024

Alternate implementation to #10325.

Instead of enabling merlin rules for all contexts, this PR applies the suggestion from #10325 (comment), by adding a generate_merlin_rules field that can be used from each context to opt-in for this behavior.

@jchavarri jchavarri force-pushed the merlin/add-generate-rules-field branch from f5e5270 to dc13809 Compare March 28, 2024 16:52
Signed-off-by: Javier Chávarri <[email protected]>
@rgrinberg
Copy link
Member

This looks like the right approach. I think you should combine this PR with #10328. It will be easier for me to asses the final result this way and the value of all of these configuration options. It would also make it easier for me to test it.

@jchavarri
Copy link
Collaborator Author

Thanks for the feedback. I incorporated these changes in #10324.

@jchavarri jchavarri closed this Apr 2, 2024
@jchavarri jchavarri deleted the merlin/add-generate-rules-field branch April 2, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants