Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with OCaml 4.14.0 #121

Open
pterjan opened this issue May 19, 2022 · 2 comments
Open

Build failure with OCaml 4.14.0 #121

pterjan opened this issue May 19, 2022 · 2 comments

Comments

@pterjan
Copy link

pterjan commented May 19, 2022

Trying to build 2.3.0 I get this error:

$ dune build -j16
File "tools/gencopy.ml", line 147, characters 60-74:
147 |         List.map2 (fun s t -> (t.id, evar s.txt)) params_in td.type_params
                                                                  ^^^^^^^^^^^^^^
Error: This expression has type type_expr list
       but an expression was expected of type transient_expr list
       Type type_expr is not compatible with type transient_expr 
@pterjan
Copy link
Author

pterjan commented May 19, 2022

I have no idea why but building with --release works, so I'll do that

@pitag-ha
Copy link
Member

Thanks for reporting! It seems like in 4.14 the compiler Types.type_expr was made abstract. We'll need to adapt ocaml-migrate-parsetree to that next time we generate a new ast module. As you've already found out that shouldn't be a problem for using ocaml-migrate-parsetree though:

I have no idea why but building with --release works, so I'll do that

Yes, that works: gencopy is only used as an internal tool by us, so with --release, dune doesn't build it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants