show/hide county field pt.2

ocadotechnology · Nov 7, 2023 · 438a97b · 438a97b
1 parent 2af2fc8
commit 438a97b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/portal/static/portal/js/onboarding_school.js → portal/static/portal/js/school.js b/portal/static/portal/js/onboarding_school.js → portal/static/portal/js/school.js
@@ -1,8 +1,10 @@
 $(document).ready(() => {
-  $('#form-row-county').hide();
+  if ($("#id_country").val() !== 'GB') {
+    $('#form-row-county').hide();
+  }
 
   $('#id_country').on('change', (event) => {
-    if (event.target.value == 'GB') {
+    if (event.target.value === 'GB') {
       $('#form-row-county').show();
     } else {
       $('#form-row-county').hide();

diff --git a/portal/templates/portal/teach/dashboard.html b/portal/templates/portal/teach/dashboard.html
@@ -235,10 +235,10 @@ <h5>Update details of your school or club</h5>
                         {{ update_school_form.non_field_errors }}
                         <div class="row form--row">
                             {% for field in update_school_form %}
-                                <div class="form--row__input col-sm-6 col-md-4">
+                                <div id="form-row-{{ field.name }}" class="form--row__input col-sm-6 col-md-4">
                                     <div class="input--icon">
                                         {{ field }}
-                                        {% if not field == update_school_form.country %}
+                                        {% if not field == update_school_form.country and not field == update_school_form.county %}
                                             <span class="iconify" data-icon="mdi:domain"></span>
                                         {% endif %}
                                     </div>
@@ -553,4 +553,7 @@ <h5>Delete account</h5>
     </div>
 </div>
 
+<script type="text/javascript"
+        src="{% static 'portal/js/school.js' %}"></script>
+
 {% endblock content %}
diff --git a/portal/templates/portal/teach/onboarding_school.html b/portal/templates/portal/teach/onboarding_school.html
@@ -61,6 +61,6 @@ <h4>Create a school or club</h4>
 {% endif %}
 
 <script type="text/javascript"
-        src="{% static 'portal/js/onboarding_school.js' %}"></script>
+        src="{% static 'portal/js/school.js' %}"></script>
 
 {% endblock content %}