Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bulk transfer students #96

Merged
merged 6 commits into from
Feb 29, 2024
Merged

fix: bulk transfer students #96

merged 6 commits into from
Feb 29, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Feb 27, 2024

This change is Reviewable

@SKairinos SKairinos changed the title Bulk transfer students fix: bulk transfer students Feb 27, 2024
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


codeforlife/tests/model_view_set.py line 255 at r1 (raw file):

    # --------------------------------------------------------------------------

    def _assert_partial_update(

Why remove partial?

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @faucomte97)


codeforlife/tests/model_view_set.py line 255 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Why remove partial?

_assert_update is used to assert both the update and partial_update actions. see the following helpers below:

  1. def partial_update
  2. def bulk_partial_update
  3. def bulk_update

instead, we now pass a bool arg called partial which denotes whether the data will contains a subset of the data or all of it contains_subset=partial.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 008eea4 into main Feb 29, 2024
4 checks passed
@SKairinos SKairinos deleted the bulk_transfer_students branch February 29, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants