-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bulk transfer students #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)
codeforlife/tests/model_view_set.py
line 255 at r1 (raw file):
# -------------------------------------------------------------------------- def _assert_partial_update(
Why remove partial?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
codeforlife/tests/model_view_set.py
line 255 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Why remove partial?
_assert_update is used to assert both the update and partial_update actions. see the following helpers below:
def partial_update
def bulk_partial_update
def bulk_update
instead, we now pass a bool arg called partial
which denotes whether the data will contains a subset of the data or all of it contains_subset=partial
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
This change is