Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset students password #88

Merged
merged 8 commits into from
Feb 20, 2024
Merged

fix: reset students password #88

merged 8 commits into from
Feb 20, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Feb 20, 2024

This change is Reviewable

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 16 files reviewed, 4 unresolved discussions


codeforlife/user/fixtures/school_1.json line 113 at r2 (raw file):

  },
  {
    "model": "common.schoolteacherinvitation",

remove and add to portal as fixture


codeforlife/user/fixtures/school_1.json line 127 at r2 (raw file):

  },
  {
    "model": "common.schoolteacherinvitation",

remove and add to portal as fixture


codeforlife/user/fixtures/school_1.json line 141 at r2 (raw file):

  },
  {
    "model": "common.schoolteacherinvitation",

remove and add to portal as fixture


codeforlife/user/models/user.py line 291 at r2 (raw file):

    # pylint: disable-next=arguments-differ
    def set_password(self):

also set login id

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 13 files at r1, 3 of 3 files at r2, 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 7ad1dff into main Feb 20, 2024
4 checks passed
@SKairinos SKairinos deleted the reset_students_password branch February 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants