Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: model view set test case #62

Merged
merged 7 commits into from
Jan 25, 2024
Merged

fix: model view set test case #62

merged 7 commits into from
Jan 25, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Jan 24, 2024

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


codeforlife/user/models/otp_bypass_token.py line 15 at r1 (raw file):

class OtpBypassToken(models.Model):
    length = 8
    allowed_chars = "abcdefghijklmnopqrstuv"

Why? Why not all the letters?

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 11 of 24 files reviewed, 1 unresolved discussion (waiting on @faucomte97)


codeforlife/user/models/otp_bypass_token.py line 15 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Why? Why not all the letters?

My bad. Fixed.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 8288825 into main Jan 25, 2024
3 of 4 checks passed
@SKairinos SKairinos deleted the create_otp_bypass_tokens branch January 25, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants