Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new permissions and fix test cases #61

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Jan 23, 2024

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


codeforlife/tests/model_view_set.py line 356 at r1 (raw file):

            model: The model to destroy.
            status_code_assertion: The expected status code.
            anonymized: Whether are not the data is anonymized.

replace are with or

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


codeforlife/tests/model_view_set.py line 356 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

replace are with or

Done.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@faucomte97 faucomte97 merged commit d6c6a7e into main Jan 24, 2024
4 checks passed
@faucomte97 faucomte97 deleted the enable_disable_otp branch January 24, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants