-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send triggered emails #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 9 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)
codeforlife/mail.py
line 298 at r3 (raw file):
if not settings.MAIL_ENABLED: logging.info(
Does this output to the terminal? If so, what's the difference between this and print
- if it is just the log level, how does it show that in the terminal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
codeforlife/mail.py
line 298 at r3 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Does this output to the terminal? If so, what's the difference between this and
A few points:
- logs are structured messages that follow an open standard (see Syslog)
- part of a log message's structure is its severity (INFO, WARN, ERROR, etc.)
- we should never use print in production servers as it will not interface with log explorers. We will be unable to filter log messages by their different dimensions. For example, we won't be able to filter to show all ERROR logs. This is critical!
- where the logs get sent to (console or other), can be configured with Python's logging handlers. Notice that I have defaulted Django's logging to print to console (StreamHandler prints to stdout a.k.a. console).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
This change is