Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add dependencies common to all packages #118

Merged
merged 4 commits into from
May 31, 2024
Merged

fix: Add dependencies common to all packages #118

merged 4 commits into from
May 31, 2024

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented May 23, 2024

This change is Reviewable

@faucomte97 faucomte97 self-assigned this May 23, 2024
Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


Pipfile line 14 at r1 (raw file):

django-cors-headers = "==4.1.0"
django-csp = "==3.7"
django-import-export = "*"

set version number

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @SKairinos)


Pipfile line 14 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

set version number

Done.

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SKairinos addressed feedback

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @SKairinos)

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


Pipfile line 6 at r2 (raw file):

name = "pypi"

[packages]

you didn't add requests

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @faucomte97)


Pipfile line 15 at r2 (raw file):

django-csp = "==3.7"
django-import-export = "==4.0.3"
pydantic = "==1.10.7"

pydantic is not used in the python package anywhere. can delete


Pipfile line 16 at r2 (raw file):

django-import-export = "==4.0.3"
pydantic = "==1.10.7"
flask = "==2.2.3"

flask is not used in the python package anywhere. can delete

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @SKairinos)


Pipfile line 6 at r2 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

you didn't add requests

cf comment in portal-react


Pipfile line 15 at r2 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

pydantic is not used in the python package anywhere. can delete

Done.


Pipfile line 16 at r2 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

flask is not used in the python package anywhere. can delete

Done.

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


Pipfile line 6 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

cf comment in portal-react

we should still add requests to our dependencies since we explicitly need it. my concern is in the future we could update to a new version of DRF that doesn't depend on requests. Therefore, we should list it as our own dependency here (which it is)

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @SKairinos)


Pipfile line 6 at r2 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

we should still add requests to our dependencies since we explicitly need it. my concern is in the future we could update to a new version of DRF that doesn't depend on requests. Therefore, we should list it as our own dependency here (which it is)

Done.

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 4a1905b into main May 31, 2024
4 checks passed
@faucomte97 faucomte97 deleted the clean_deps branch May 31, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants