-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add dependencies common to all packages #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
Pipfile
line 14 at r1 (raw file):
django-cors-headers = "==4.1.0" django-csp = "==3.7" django-import-export = "*"
set version number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @SKairinos)
Pipfile
line 14 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
set version number
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SKairinos addressed feedback
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @SKairinos)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
Pipfile
line 6 at r2 (raw file):
name = "pypi" [packages]
you didn't add requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @faucomte97)
Pipfile
line 15 at r2 (raw file):
django-csp = "==3.7" django-import-export = "==4.0.3" pydantic = "==1.10.7"
pydantic is not used in the python package anywhere. can delete
Pipfile
line 16 at r2 (raw file):
django-import-export = "==4.0.3" pydantic = "==1.10.7" flask = "==2.2.3"
flask is not used in the python package anywhere. can delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @SKairinos)
Pipfile
line 6 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
you didn't add requests
cf comment in portal-react
Pipfile
line 15 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
pydantic is not used in the python package anywhere. can delete
Done.
Pipfile
line 16 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
flask is not used in the python package anywhere. can delete
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
Pipfile
line 6 at r2 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
cf comment in portal-react
we should still add requests to our dependencies since we explicitly need it. my concern is in the future we could update to a new version of DRF that doesn't depend on requests. Therefore, we should list it as our own dependency here (which it is)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @SKairinos)
Pipfile
line 6 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
we should still add requests to our dependencies since we explicitly need it. my concern is in the future we could update to a new version of DRF that doesn't depend on requests. Therefore, we should list it as our own dependency here (which it is)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
This change is