fix: Portal frontend#7

[SKairinos]

This change is 

[faucomte97]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)

---

src/components/form/DatePickerField.tsx line 61 at r1 (raw file):

      `this field must be less or equal to ${dateToString(maxDate)}`,
    )
  }

Maybe a pointless concern of mine, but do people instinctively understand "greater or equal to" when talking about dates? I think people are more used to "before or after" a certain date, "greater" or "less than" a date is a very developer-specific way of phrasing it.

Code quote:

    schema = schema.min(
      minDate,
      `this field must be greater or equal to ${dateToString(minDate)}`,
    )
  }
  if (maxDate) {
    schema = schema.max(
      maxDate,
      `this field must be less or equal to ${dateToString(maxDate)}`,
    )
  }

[SKairinos]

Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @faucomte97)

---

src/components/form/DatePickerField.tsx line 61 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Maybe a pointless concern of mine, but do people instinctively understand "greater or equal to" when talking about dates? I think people are more used to "before or after" a certain date, "greater" or "less than" a date is a very developer-specific way of phrasing it.

Done. Agreed.

[faucomte97]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)