Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Hydrate some events with additional data in comparison to the v4 counterparts #983

Open
BarryCarlyon opened this issue Aug 15, 2022 · 8 comments · May be fixed by #1229
Open

Comments

@BarryCarlyon
Copy link
Contributor

Feature Request Type

RPC Event

Feature Request Type (Other)

No response

Requested Feature

Comparing v4 to v5 a number of events are "dry" on the data they send.

For example SceneTransitionStarted only decalres the kind of transition that is occuring.

The v4 equivalent being TransitionBegin decarles additional information with the event including the duration and from/to scenes

I imaging there are similar "problems" with other events being "dry" on data when compared to their v4 counter parts. But I'm just getting started on planning my OBS 27 to 28 migration paths.

I will likely update this issue with other "dry" events as I poke around

Requested Feature Usage Scenario

In the example of SceneTransitionStarted.

I detect the duration of the event and the destination scene.
Half way thru the transition I run actions or tasks based on the destination scene.

So I need this information as the transitions starts

@BarryCarlyon BarryCarlyon changed the title Feature Request: Hydrate some events with additional data Feature Request: Hydrate some events with additional data in comparison to the v4 counterparts Aug 15, 2022
@deeoncomms
Copy link

I agree with this - I set up some events for an obs scene collection to show or hide certain elements of a nested scene depending on the live scene, and because of that setup, anything other than a cut transition looks awkward using the SwitchScenes (4.x) or CurrentProgramSceneChanged (5.x) events due to the source visibility change happening after the transition is over.

@ChristopheCVB
Copy link
Contributor

Same for SceneTransitionEnded, lacks the toScene

@tinodo
Copy link

tinodo commented Oct 25, 2022

Okay, another +1 for this. Getting the fromScene and toScene is rather important to me as well. I used this very frequently and stops me from upgrading to the latest version.

@cai-tan
Copy link

cai-tan commented Sep 2, 2023

Actually kind of insane this still hasn't been updated an entire year later. Why was fromScene and toScene even removed in the first place?

@zoton2
Copy link

zoton2 commented Jan 16, 2024

Should this issue be broken down into more issues? Did @BarryCarlyon find any more issues in migration? I'm currently migrating and would really like to have at least the to/from scenes in SceneTransitionStarted. 4.x did that with a custom function, GetTransitionData, but I think the data/APIs it uses do still exist in OBS, just not sure how hacky this custom function was.

@duncte123 duncte123 linked a pull request Jun 5, 2024 that will close this issue
5 tasks
@duncte123
Copy link

duncte123 commented Jun 5, 2024

Created a PR for this functionality, still looking into setting the duration on the response properly but the current patch works like a charm #1229

@duncte123
Copy link

Little update from my side, here are windows and linux binaries if you want to use this already. These are the binary files only since the language files have not updated (you can always compile the PR yourself if you don't trust these downloads)

obs-websocket-linux.zip
obs-websocket-windows-x64.zip

@duncte123
Copy link

I've created a new build of the websocket DLL that is based on 5.5.3
obs-websocket-win-x64.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants