cmake: Fix build directory exclusion #11501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex was incorrectly excluding any file with build in the name. The intent was to exclude any build directories, so we should be able to restrict this.
RytoEX
added
Bug Fix
PatTheMav
reviewed
Nov 11, 2024
| @@ -16,7 +16,7 @@ endif() | |||
|
|
|||
| set(CPACK_SOURCE_PACKAGE_FILE_NAME "obs-studio-${CPACK_PACKAGE_VERSION}-sources") | |||
| set(CPACK_SOURCE_GENERATOR "TGZ") | |||
| set(CPACK_SOURCE_IGNORE_FILES "/.git" "/.*build.*" "/.ccache" "/.deps") | |||
| set(CPACK_SOURCE_IGNORE_FILES "/.git" "/build.*" "/.ccache" "/.deps") | |||
There was a problem hiding this comment.
This make it still ignore buildspec.json as that matches the regular expression build.* - that file is also missing from the tarball.
|
I'm not sure if the "proper" fix is to remove the tarball entirely - given that only one user has reported that defect (and didn't even notice the entire extent of it), it seems like we already spent too much maintenance effort on a very niche requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The regex was incorrectly excluding any file with build in the name. The intent was to exclude any build directories, so we should be able to restrict this.
Motivation and Context
Fixes #11443.
How Has This Been Tested?
It hasn't.
Types of changes
Checklist: