Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with duplicate files GitHub Theme/GitHub theme #598

Closed
claremacrae opened this issue Jan 30, 2023 · 1 comment
Closed

Deal with duplicate files GitHub Theme/GitHub theme #598

claremacrae opened this issue Jan 30, 2023 · 1 comment
Labels
hub tools & scripts

Comments

@claremacrae
Copy link
Contributor

From Discord https://discord.com/channels/686053708261228577/915679988118863933/1069568350050586654

PR #596 has created a duplicate file differing only in file case...

I thought I would grab a few minutes to approve and publish the updates from last week...
I reviewed them on GitHub, which ran with no errors. Then approved.

Now I come to publish, I see this:

image

Sure enough there are two files differing only in case of name...

image

We thought we had checks to trap this, but for some reason they didn't spot it.

So apologies but I have no time to deal with this until next weekend at the earliest...

The check ran, and seemingly did not spot this pair.
https://github.com/obsidian-community/obsidian-hub/actions/runs/4042915136/jobs/6951202666

image
andynu added a commit to andynu/obsidian-hub that referenced this issue Mar 21, 2023
@andynu
Remove case conflicting GitHub Theme file.
77c49f4 
The GitHub theme is the original.

Issue obsidian-community#598
@andynu andynu mentioned this issue Mar 21, 2023
Merged
This was referenced Mar 21, 2023
Closed
Closed
Merged
@claremacrae
Copy link
Contributor Author

This has been fixed by #607 and #608.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hub tools & scripts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@claremacrae