fix(#1426): introduced new Footprint that knows about cache
#3425
+1,057
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yegor256 please check |
yegor256
reviewed
Oct 18, 2024
yegor256
reviewed
Oct 18, 2024
yegor256
reviewed
Oct 18, 2024
yegor256
reviewed
Oct 18, 2024
eo-maven-plugin/src/main/java/org/eolang/maven/fp/Footprint.java
Outdated
Show resolved
Hide resolved
yegor256
reviewed
Oct 18, 2024
eo-maven-plugin/src/main/java/org/eolang/maven/fp/Footprint.java
Outdated
Show resolved
Hide resolved
yegor256
reviewed
Oct 18, 2024
eo-maven-plugin/src/main/java/org/eolang/maven/fp/Footprint.java
Outdated
Show resolved
Hide resolved
yegor256
reviewed
Oct 18, 2024
eo-maven-plugin/src/main/java/org/eolang/maven/fp/Footprint.java
Outdated
Show resolved
Hide resolved
yegor256
reviewed
Oct 18, 2024
eo-maven-plugin/src/main/java/org/eolang/maven/fp/Footprint.java
Outdated
Show resolved
Hide resolved
|
@maxonfjvipon looks cool! However, there are a few comments about the design, see above. |
|
@yegor256 fixed, please check one more time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1426
PR-Codex overview
This PR introduces MIT License comments for various classes and adds unit tests for the
Cache,CacheVersion, andFootprintclasses in theorg.eolang.maven.fppackage, enhancing the code's documentation and test coverage.Detailed summary
package-info.java,Cache.java,CacheVersion.java,Saved.java,Footprint.java, and test files.CacheTestclass to test the functionality ofCache.CacheVersionTestclass to validate cache version handling.FootprintTestclass to ensure correct file handling logic inFootprint.